635430 - Embedded YouTube and some other Flash contents show outlines on clicking

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[David Hsu]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110218 Firefox/4.0b12pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110218 Firefox/4.0b12pre

When clicking on some Flash content, outlines show up and still do after setting the browser.display.focus_ring_width to 0. 

Reproducible: Always




This is a regression between 20101023 and 20101024, changes are:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=733280bfc136&tochange=094d838ed780

Comment 1

[David Hsu]

Attachment: 20101023

Comment 2

[David Hsu]

Attachment: 20101024

Comment 3

[Boris Zbarsky [:bzbarsky]]

See bug 541406 (which got backed out in the range above).

The pref you mention only affects focus rings on buttons and anchors, which are not set in html.css.  See PresShell::SetPrefFocusRules.

None of this has anything to do with plug-ins per se...

Comment 4

[David Hsu]

(In reply to comment #3)

I didn't really know which component to choose exactly, just making an assumption. Thanks.

Comment 5

[David Hsu]

Nobody confirming... so is the outline around plug-ins intended?
Any way to disable it?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> is the outline around plug-ins intended?

Yes.

> Any way to disable it?

Yes; you could just have a user style rule overriding the UA style rule in question.

Comment 7

[David Hsu]

Alright... as much as I'm still confused about showing the outline around plug-ins, I suppose this is a WONTFIX then?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Why is it confusing?  The plug-in has focus; it should have a focus outline just like other things that can take focus...

Comment 9

[David Hsu]

I just thought that maybe showing them only when "tab" through page elements would be better than having to see them every time I click on something.

Well then, could you show me how to hide them via user styles?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Normally if you just click on it you shouldn't get a focus outline, unless the OS convention on your OS is that it should...

You can take the style rule at http://hg.mozilla.org/mozilla-central/file/1da3405c74fd/layout/style/html.css#l697, copy it into your user stylesheet, and adjust as desired.

Comment 11

[David Hsu]

That'll do. Thanks!

(FWIW, I do just click on it, and I'm only seeing this in Firefox.)

Comment 12

[Boris Zbarsky [:bzbarsky]]

On mac, the default OS behavior is that if something takes the focus at all, it gets a focus outline, no matter how it was focused.

On Windows, the behavior is very different....

Comment 13

[David Hsu]

I don't see the behavior in other browsers though... (including Safari)

Comment 14

[Boris Zbarsky [:bzbarsky]]

Sure; browsers don't always follow OS UI conventions.  Safari certainly violates the Mac ones in all sorts of cases.

Comment 15

[David Hsu]

I think you may stop trying to convince me because I still don't get why Firefox does this when nobody else does...
I'm gonna stop spamming the bug :P Thanks anyway.