63552 - We're leaking one nsSecureBrowserUIImpl per window

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Conrad Carlen (not reading bugmail)]

nsSecureBrowserUIImpl::Init calls nsIObserverService::AddObserver() with itself
as the param. Because nsSecureBrowserUIImpl does not mix in
nsSupportsWeakReference, the observer service makes a strong reference to it.
Since the observer service doesn't go away until quit time, neither do any of
the nsSecureBrowserUIImpls. nsSecureBrowserUIImpl should implement
nsSupportsWeakReference and this wouldn't happen. Whoever made the object should
hold the one strong ref to it. The patch here fixes that. I tested it with my
embedding app and the nsSecureBrowserUIImpl goes away when the browser window is
destroyed. For SeaMonkey, the code at
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/src/nsBrowserInstance.cpp#485
would have to change.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to use nsSupportsWeakReference

Comment 2

[Judson Valeski]

fixed via http://bugzilla.mozilla.org/show_bug.cgi?id=65925

Comment 3

[John Unruh]

Verified per Judson's comments.

Comment 4

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 5

[John Unruh]

Mass changing Security:Crypto to PSM