Closed Bug 635540 Opened 9 years ago Closed 9 years ago

Fix some browser-chrome tests

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I found many of the current browser-chrome failures were due to a mistake in the browser_scrollbar.js code. It tries to cleanup any tabs opened during the test, but instead seems to close some tab opened in other tests as well.

The fix is to explicitly track just the scrollbar tabs and close them when finished.

Four (4) of the browser_tapping.js tests seem to be failing for reasons other than the scrollbar code. I tried a few things, including sending the mouse events to the notificationbox, not the browser, but not all tests went green. There is more work to do there, but I left the notificationbox fixes in place.
Attachment #513793 - Flags: review?(mbrubeck)
Oops, I meant two (2) of the tapping tests are still failing
Attachment #513793 - Flags: review?(mbrubeck) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/e682232b0dbb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.