Closed
Bug 635540
Opened 13 years ago
Closed 13 years ago
Fix some browser-chrome tests
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
9.77 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
I found many of the current browser-chrome failures were due to a mistake in the browser_scrollbar.js code. It tries to cleanup any tabs opened during the test, but instead seems to close some tab opened in other tests as well. The fix is to explicitly track just the scrollbar tabs and close them when finished. Four (4) of the browser_tapping.js tests seem to be failing for reasons other than the scrollbar code. I tried a few things, including sending the mouse events to the notificationbox, not the browser, but not all tests went green. There is more work to do there, but I left the notificationbox fixes in place.
Attachment #513793 -
Flags: review?(mbrubeck)
Assignee | ||
Comment 1•13 years ago
|
||
Oops, I meant two (2) of the tapping tests are still failing
Updated•13 years ago
|
Attachment #513793 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 2•13 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/e682232b0dbb
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•