Closed Bug 635544 Opened 9 years ago Closed 8 years ago

rename nsIWidget::DrawOver

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: joe, Assigned: BenWa)

Details

Attachments

(1 file)

Jeff thinks that DrawOver and DrawUnder are not sufficiently descriptive names.

> Renaming DrawOver might also be a good idea. The current name makes you ask
Draw what? Over what?
Jeff/Joe any idea what that rename should be? I'll post the patch and get this bug closed.
There is no DrawUnder.

Maybe DrawOver -> DrawWindowOverlay?
Summary: rename nsIWidget::DrawOver/nsIWidget::DrawUnder → rename nsIWidget::DrawOver
Attached patch patchSplinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #590463 - Flags: review?(roc)
Try run for 43135679b839 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=43135679b839
Results (out of 4 total builds):
    success: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/b56girard@gmail.com-43135679b839
https://hg.mozilla.org/mozilla-central/rev/40bc6b9b09d1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.