Last Comment Bug 635619 - Mac platformBrowserBindings has incorrect keyset id
: Mac platformBrowserBindings has incorrect keyset id
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-20 10:18 PST by Ian Neal
Modified: 2011-02-22 13:59 PST (History)
2 users (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Correct the id [Checked in: Comment 3] (810 bytes, patch)
2011-02-20 10:18 PST, Ian Neal
stefanh: review+
Details | Diff | Review

Description Ian Neal 2011-02-20 10:18:16 PST
Created attachment 513875 [details] [diff] [review]
Correct the id [Checked in: Comment 3]

Whilst working on another bug I spotted that the keyset id in suite/common/mac/platformBrowserBindings.xul is different to the equivalent files for win and unix.
Patch makes it match the offers.
Comment 1 Philip Chee 2011-02-21 03:08:35 PST
Does anything actually use editorKeySet? I searched MXR all the way back to Mozilla1.7.
Comment 2 Stefan [:stefanh] (away until May 28) 2011-02-22 13:44:18 PST
Comment on attachment 513875 [details] [diff] [review]
Correct the id [Checked in: Comment 3]

Actually, nothing seems to use globalKeySet either. But if we shall keep the id's, mac shouldn't differ.
Comment 3 Ian Neal 2011-02-22 13:59:39 PST
Comment on attachment 513875 [details] [diff] [review]
Correct the id [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/68e7befc812c

Note You need to log in before you can comment on or make changes to this bug.