Add locales to KNOWN_LANGUAGES

RESOLVED FIXED in 1.0

Status

Websites
demos.mozilla.org
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stas, Assigned: ozten)

Tracking

unspecified

Details

(Reporter)

Description

7 years ago
I'll update this bug with more locales as we add them.

Please add 'ar'.
(Reporter)

Comment 1

7 years ago
Oh, and for 'ar', can you uncomment it in RTL_LANGUAGES, too?
Assignee: nobody → ozten.bugs
Blocks: 600772
Priority: -- → P1
Target Milestone: --- → 1.0
(Assignee)

Comment 2

7 years ago
I'm sure we're going to have some RTL issues :(

Done.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

7 years ago
Can I reopen this bug if there's more locales to add, or do you want me to file new ones?
(Assignee)

Comment 4

7 years ago
Please re-open for adding new locales.
(Reporter)

Comment 5

7 years ago
Please add 'it' and 'fr'.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
not sure if it's related, but I can't get updated "pl" version of the site.
(Reporter)

Comment 7

7 years ago
Don't think so, I can see 'pl' in there: https://github.com/mozilla/webowonder/blob/master/settings.py#L50
should I then file a separate bug on stage not being updated?

There seems to be a gap between what's here https://localize.mozilla.org/pl/webowonder/ and here http://webofwonder.allizom.org/pl/
(Reporter)

Comment 9

7 years ago
Gandalf, I filed bug 637012.  Let's discuss there.
(Assignee)

Comment 10

7 years ago
Added 'it' and 'fr'.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
please, add "tr".
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
and "tr" and "si"
sorry, "th" and "si" ("tr" as well of course ;))
(Assignee)

Comment 15

7 years ago
Should all these locales ship to production today?
(Assignee)

Comment 16

7 years ago
Added: th, tr, pt, si
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
and "sq"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

7 years ago
Per gandalf we're going live with:
ar, ca, zh_TW, fr, hu, id, ga, it, ja, pl, rm, ru, sl, es
updated list:
ar, ca, zh_TW, fr, hu, id, ga, it, ja, pl, rm, ru, sl, es, pt, si,
(Assignee)

Comment 20

7 years ago
Updated on prod branch. Will go out with 1.0.4 push before launch.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
updated list:
ar, ca, zh_TW, fr, hu, id, ga, it, ja, pl, rm, ru, sl, es, pt, si, cs, nl, de, fy, ja, tr, sq
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 22

7 years ago
KNOWN_LANGUAGES = ('en-US', 'ar', 'ca', 'cs', 'de', 'es', 'fr', 'fy', 'ga', 'hu', 'id', 'it', 'ja', 'nl', 'pl', 'pt', 'rm', 'ru', 'si', 'sl', 'sq', 'tr', 'zh_TW')
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
please, add "ko" to KNOWN_LANGUAGES
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 24

7 years ago
Done in 334dfea..11c656d
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
updated list for production: 

KNOWN_LANGUAGES = ('en-US', 'ar', 'ca', 'cs', 'de', 'el', 'es', 'fr', 'fy', 'ga', 'he', 'hu', 'id', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'rm', 'ru', 'si', 'sl', 'sq', 'th', 'tr', 'zh-CN', 'zh_TW')

5 new locales: ko, he, th, zh-CN and el
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 26

7 years ago
Gandalf, your list has zh-CN (with a hyphen) and zh_TW (with an underscore).  Shouldn't they be standardized?
(Reporter)

Comment 27

7 years ago
OK, talked to Gandalf IRL, hyphen it is.

Ozten, please use this line:

KNOWN_LANGUAGES = ('en-US', 'ar', 'ca', 'cs', 'de', 'el', 'es', 'fr', 'fy',
'ga', 'he', 'hu', 'id', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'rm', 'ru', 'si',
'sl', 'sq', 'th', 'tr', 'zh-CN', 'zh-TW')
(Assignee)

Comment 28

7 years ago
Shipping to prod tommorrow:
KNOWN_LANGUAGES = ('en-US', 'ar', 'ca', 'cs', 'de', 'el', 'es', 'fr', 'fy',
'ga', 'he', 'hu', 'id', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'rm', 'ru', 'si',
'sl', 'sq', 'th', 'tr', 'zh-CN', 'zh-TW')

Done in 2e69e51..e83253b
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 29

7 years ago
Ozten, can you add Basque (eu) as well?  We'd like to first see it on staging only, is that still possible with the current branch layout?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 30

7 years ago
Done
Staging has 
KNOWN_LANGUAGES = ('en-US', 'ar', 'ca', 'cs', 'de','el', 'es', 'eu', 'fr', 'fy', 'ga', 'he', 'hu', 'id', 'it', 'ja', 'ko', 'nl', 'pl', 'pt', 'rm', 'ro', 'ru', 'si', 'sl', 'sr', 'sq', 'th', 'tr', 'zh-CN', 'zh-TW')
(Assignee)

Comment 31

7 years ago
We just found out that stage was not auto-updating. This is fixed now. 

I see http://webofwonder.allizom.org/eu/
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.