635898 - add tpaint and ts_paint to the graph server

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

as per bug 612190, we want to start measuring a different time for twinopen and ts.  Unfortunately this measurement code doesn't live on all branches, so we are creating 2 new test types which will be run on mozilla-central for now:
 - ts_paint (will end up replacing ts)
 - tpaint (will end up replace twinopen/txul)

On a talos staging run these fail because the graph server doesn't know about these tests.

Comment 1

[cmtalbert]

Hey rhelmer,

Can we get some graphserver love on this?  I'm not exactly sure who else might be the right person to cc.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to comment #1)
> Hey rhelmer,
> 
> Can we get some graphserver love on this?  I'm not exactly sure who else might
> be the right person to cc.

I think this just requires a schema change; releng usually does this I think. cc'ing catlee, who should know :)

Comment 3

[Chris AtLee [:catlee]]

No schema changes required, just new entries in the 'tests' table. e.g. http://hg.mozilla.org/graphs/rev/9c02347596b4

Comment 4

[Jim Mathies [:jimm]]

Attachment: [checked in]add ts_paint and tpaint to graphs

I went with pretty names of 'Paint' and 'Ts, Paint'.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 515144 [details] [diff] [review]
[checked in]add ts_paint and tpaint to graphs

stamp

Comment 6

[Jim Mathies [:jimm]]

So I can land this and we should be good to go? No other changes required?

Comment 7

[[e-mail] (:bhearsum)]

You need to have IT run those two lines on both the production and stage graph servers. File a bug like this one to get it done:
https://bugzilla.mozilla.org/show_bug.cgi?id=637360

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> You need to have IT run those two lines on both the production and stage graph
> servers. File a bug like this one to get it done:
> https://bugzilla.mozilla.org/show_bug.cgi?id=637360

Thanks Ben, filed bug 637371.

Comment 9

[Jim Mathies [:jimm]]

Can this be closed out now? Looks like bug 637371 accomplished the work needed.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

verified in talos-staging that we can generate results and upload successfully to the graph server!

Comment 11

[alice nodelman [:alice] [:anode]]

This patch was never checked into the graph server code - should do that for sanity.

Comment 12

[alice nodelman [:alice] [:anode]]

Comment on attachment 515144 [details] [diff] [review]
[checked in]add ts_paint and tpaint to graphs

changeset:   340:a656708d82cd

Comment 13

[Chris Cooper [:coop] (he/him)]

Comment on attachment 515144 [details] [diff] [review]
[checked in]add ts_paint and tpaint to graphs

Alice checked this in:

http://hg.mozilla.org/graphs/rev/a656708d82cd