Closed Bug 635937 Opened 9 years ago Closed 9 years ago

"Your add-ons have been updated" text not readable on OSX because of color

Categories

(Toolkit :: Add-ons Manager, defect)

All
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0
Tracking Status
blocking2.0 --- -

People

(Reporter: jboriss, Assigned: jboriss)

Details

(Keywords: polish, Whiteboard: [addons-testday])

Attachments

(2 files, 2 obsolete files)

Current text is a light lime green that does not display well against the background of the manager.  Intended color is #3c735c (see attached)
I really really want to see this fixed, and it looks like a simple CSS change, but I don't think we'd block for it, just be very sad if we don't see a patch for it that we can approve in the next couple of days.

--> Unfocused.
Assignee: nobody → bmcbride
blocking2.0: ? → -
Whiteboard: [good first bug]
Assignee: bmcbride → jboriss
OS: Mac OS X → Windows 7
Attached patch patch (obsolete) — Splinter Review
Attachment #514642 - Flags: review?
Attachment #514642 - Flags: review? → review?(dao)
OS: Windows 7 → Windows XP
Whiteboard: [good first bug]
OS: Windows XP → Mac OS X
Driveby: Doesn't follow the convention of using uppercase letters in hex values.
That convention is news to me!
Comment on attachment 514642 [details] [diff] [review]
patch

>diff --git a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>--- a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>+++ b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>@@ -981,17 +981,17 @@
> /*** check for updates ***/
> 
> #updates-container {
>   -moz-box-align: center;
> }
> 
> #updates-installed,
> #updates-downloaded {
>-  color: #00BB00;
>+  color: #3C735C;
>   font-weight: bold;
> }
> 
> #update-selected {
>   margin: 12px;
> }
> 
>
Attached file patchv2 (obsolete) —
(In reply to comment #4)
> That convention is news to me!

News to me too!  fixed.
Attachment #514642 - Attachment is obsolete: true
Attachment #514642 - Flags: review?(dao)
Attached patch patchv2Splinter Review
Attachment #514665 - Attachment is obsolete: true
Attachment #514666 - Flags: review?(dao)
(In reply to comment #4)
> That convention is news to me!

Well, it may not be a global convention, but it is whats used in the addons manager.
Attachment #514666 - Flags: review?(dao) → review+
Keywords: polishcheckin-needed
Attachment #514666 - Flags: approval2.0?
Keywords: polish
Comment on attachment 514666 [details] [diff] [review]
patchv2

a=beltzner
Attachment #514666 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/96b0a0ff6266
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [addons-testday]
You need to log in before you can comment on or make changes to this bug.