635937 - "Your add-ons have been updated" text not readable on OSX because of color

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Current vs intended color for text

Current text is a light lime green that does not display well against the background of the manager.  Intended color is #3c735c (see attached)

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I really really want to see this fixed, and it looks like a simple CSS change, but I don't think we'd block for it, just be very sad if we don't see a patch for it that we can approve in the next couple of days.

--> Unfocused.

Comment 2

[Jennifer Morrow [:Boriss] (UX)]

Attachment: patch

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Driveby: Doesn't follow the convention of using uppercase letters in hex values.

Comment 4

[Dão Gottwald [:dao]]

That convention is news to me!

Comment 5

[Jennifer Morrow [:Boriss] (UX)]

Comment on attachment 514642 [details] [diff] [review]
patch

>diff --git a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>--- a/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>+++ b/toolkit/themes/pinstripe/mozapps/extensions/extensions.css
>@@ -981,17 +981,17 @@
> /*** check for updates ***/
> 
> #updates-container {
>   -moz-box-align: center;
> }
> 
> #updates-installed,
> #updates-downloaded {
>-  color: #00BB00;
>+  color: #3C735C;
>   font-weight: bold;
> }
> 
> #update-selected {
>   margin: 12px;
> }
> 
>

Comment 6

[Jennifer Morrow [:Boriss] (UX)]

Attachment: patchv2

(In reply to comment #4)
> That convention is news to me!

News to me too!  fixed.

Comment 7

[Jennifer Morrow [:Boriss] (UX)]

Attachment: patchv2

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> That convention is news to me!

Well, it may not be a global convention, but it is whats used in the addons manager.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 514666 [details] [diff] [review]
patchv2

a=beltzner

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/96b0a0ff6266

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0