635942 - Search by submission date does not return any results

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Upload a new add-on and choose full review
2. Load https://addons.allizom.org/z/en-US/editors/queue/nominated
2. In Advanced Search, select submission days to 1 day

expected behavior:
The newly submitted add-on is listed in the search results

actual behavior:
No search results found

Also:
This feature is broken in allizom remora but works fine in prod.

Comment 1

[Kumar McMillan [:kumar]]

Jorge, what is the desired behavior for selecting Days Since Submission = 1?

The current code will give you, literally, all addons submitted a day ago.  It sounds like Krupa is expecting it to give you addons submitted anytime *between* now and a day ago.  In other words, for it to show all addons submitted today and yesterday.  I'm not sure what remora does; I can change it to whatever works best.

Note that this is different than Days Since Submission = 2 or 3, etc.  Those queries will show you addons submitted 2 days ago, 3 days ago, ....

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I think it's more useful to show add-ons that have were submitted in X days or less. The ones that have been submitted exactly X days ago will appear at the top anyway, so it is effective regardless of interpretation.

Comment 3

[Kumar McMillan [:kumar]]

ok, I made it work like Jorge describes: https://github.com/jbalogh/zamboni/commit/795d951211393ed819bc0be6286fd547ea874672

Comment 4

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/z/en-US/editors/queue/nominated?text_query=&admin_review=&application_id=&max_version=&waiting_time_days=1

Comment 5

[krupa raj[:krupa]]

Attachment: post-fix screenshot