Check Items.arrange() calls to make sure tab bounds are correctly calculated

RESOLVED FIXED

Status

P4
normal
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Details

"Checking" can happen after beta 12. Hopefully we'll discover that nothing needs to actually happen as a result.
Blocks: 585689
No longer blocks: 627096

Updated

8 years ago
Priority: -- → P4
Just to clarify: this task is about the first argument of Items.arrange, whose spec changed during development... at first, Items.arrange(array, ...) would actually move the items in that array around, but it currently does not. Thus, right now, we should *always* be giving the list of children, etc., to Items.arrange as its first argument, *unless* there are no physical items.

tl;dr: we should check what first argument is passed to Items.arrange in the codebase, and make sure they all make sense.
(Assignee)

Comment 3

8 years ago
There are two calls:

1.) groupitems.js:1225 [groupItem.shouldStack()] - This one will be fixed with bug 634672.

2.) groupitems.js:1408 [groupItem._gridArrange()] - After that call items will be actually arranged. The first argument is the list of all children to arrange.
Assignee: nobody → tim.taubert
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.