635943 - Check Items.arrange() calls to make sure tab bounds are correctly calculated

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Tim Taubert [:ttaubert] (inactive)]

Follow up of https://bugzilla.mozilla.org/show_bug.cgi?id=634672#c16.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

"Checking" can happen after beta 12. Hopefully we'll discover that nothing needs to actually happen as a result.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

Just to clarify: this task is about the first argument of Items.arrange, whose spec changed during development... at first, Items.arrange(array, ...) would actually move the items in that array around, but it currently does not. Thus, right now, we should *always* be giving the list of children, etc., to Items.arrange as its first argument, *unless* there are no physical items.

tl;dr: we should check what first argument is passed to Items.arrange in the codebase, and make sure they all make sense.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

There are two calls:

1.) groupitems.js:1225 [groupItem.shouldStack()] - This one will be fixed with bug 634672.

2.) groupitems.js:1408 [groupItem._gridArrange()] - After that call items will be actually arranged. The first argument is the list of all children to arrange.