Closed Bug 635966 Opened 9 years ago Closed 9 years ago

elfhack fails with llvm LTO

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: espindola, Assigned: glandium)

Details

Attachments

(3 files, 1 obsolete file)

A build with both LTO and elfhack fails at

/home/espindola/tmpfs/objdir-lto-clang/build/unix/elfhack/elfhack -b test.so
test.so: No gain. Aborting
Turns out it's the same problem as the other bug
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 635961
I have to retract, it looks like it's different. If I remove the relro section, it still says No gain.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Ah, this is an interesting case where test.so is too optimized and doesn't exhibit the patterns that are expected to show up from the source... In the present case, there are no relocations...
Assignee: nobody → mh+mozilla
There are two different things mixed in this patch, but they are two one-liners:
- the rule to build the dummy binary works for gcc but not for clang because of missing flags
- the test library is over-optimized by clang/gold, and ends up not containing most of the code from test.c, making the testcase not contain what we expect it to. Forcing to build at the lowest optimization level avoids surprises.
Attachment #514296 - Flags: review?(khuey)
Attachment #514295 - Attachment is obsolete: true
Comment on attachment 514296 [details] [diff] [review]
Avoid elfhack failure with llvm

See comment 6. No risk.
Attachment #514296 - Flags: approval2.0?
Comment on attachment 514296 [details] [diff] [review]
Avoid elfhack failure with llvm

if this causes so much as a blip on the tinderbox radar, it comes out until after 4.
Attachment #514296 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/494662b968c2
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.