Closed
Bug 636014
Opened 12 years ago
Closed 11 years ago
[autoconfig] Align labels and textfields on the existing account wizard
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird11 fixed, thunderbird12 fixed)
RESOLVED
FIXED
Thunderbird 13.0
People
(Reporter: BenB, Assigned: standard8)
References
Details
Attachments
(3 files, 1 obsolete file)
10.75 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review-
|
Details | Diff | Splinter Review |
10.73 KB,
patch
|
andreasn
:
ui-review+
BenB
:
feedback+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
21.89 KB,
image/png
|
Details |
The name/email/password fields in the Account Creation wizard have labels with a class="autoconfigLabel" which just sets a certain width in em. If any of the labels is longer, the textfields are misaligned. You can see tat in TB 3.1 in French, it looks really awful. The bug is assuming that the labels are smaller than so-and-so em. Similarly, in the Result display (after we found a working config automatically), the "Incoming"/"Outgoing"/"Username" labels are not base-aligned. Maybe because the labels have a smaller font. <hbox align="baseline"> doesn't fix it. Also, they should use a <grid>, too, for the same reason as above.
Reporter | ||
Comment 1•11 years ago
|
||
https://bugzilla.mozilla.org/attachment.cgi?id=554712
Assignee | ||
Comment 3•11 years ago
|
||
Work in progress fix. This does: - use grids for the problem areas to account for different length of strings. - currently uses sizeToContent to fix the problem where the error text goes off the window. This doesn't yet fix the vertical alignment of the results when something is found in ispdb.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Summary: [autoconfig] Align labels and textfields → [autoconfig] Align labels and textfields on the existing account wizard
Assignee | ||
Comment 4•11 years ago
|
||
For the vertical mis-alignment, I've been able to fix it by changing the descriptions to a textbox, but making that textbox disabled and look the same as a label. This is also good from the a11y point of view as it means we can link the labels to the text. I'm a bit concerned about overrunning the window width, but I'm failure sure we're not going to hit really long configs. If we do, then we might have to reconsider it, but generally this should look a lot better than it does now for the majority of cases. For the sizeToContent issue, I had a look at doing it a slightly different way, but that didn't work unfortunately, so for now, this is the best I can do, but I'll file a follow-up bug if you want.
Attachment #576165 -
Attachment is obsolete: true
Attachment #576713 -
Flags: ui-review?(bwinton)
Attachment #576713 -
Flags: review?(bwinton)
Comment 5•11 years ago
|
||
Comment on attachment 576713 [details] [diff] [review] The fix Review of attachment 576713 [details] [diff] [review]: ----------------------------------------------------------------- On Windows: Hit tab, type "jdfkls@fjdls.fdjskl", hit tab, hit shift-tab, type "fjdkls", hit shift-tab, type "fjdsklfdjskl", hit tab a bunch, and watch the fields change width. Because of this, I'm going to have to give this a ui-r-. But the code seems good, so it gets an r=me. :) Thanks, Blake.
Attachment #576713 -
Flags: ui-review?(bwinton)
Attachment #576713 -
Flags: ui-review-
Attachment #576713 -
Flags: review?(bwinton)
Attachment #576713 -
Flags: review+
Assignee | ||
Comment 6•11 years ago
|
||
Andreas/Richard, would you be able to look at comment 5 for me? I can't reproduce that on Mac.
Comment 7•11 years ago
|
||
I can confirm this behavior on Win7. This is because the password textbox is using italic text for the placeholder and switches to normal when the textbox is active. When you set #password {width: 165px;} the box width is stable. I think the width is dynamically calculated based on the font and italic is wider than normal. PS: The same happens with the Gloda searchbox.
Comment 8•11 years ago
|
||
Richard any quick fixes coming to your mind ?
Comment 9•11 years ago
|
||
The only quick fix would be to use non-italic text. If this is okay I can write a patch for this. Blake, what do you mean?
Comment 10•11 years ago
|
||
Can you whip up a patch with non-italic text, and we can see how that looks? Thanks, Blake.
Comment 11•11 years ago
|
||
This patch is based on Mark's patch with this changes in mail/themes/qute/mail/accountCreation.css: I added @namespace html url("http://www.w3.org/1999/xhtml"); and textbox.padded html|*.textbox-input:-moz-placeholder { font-style: normal; } Because of this I'm asking only for ui-r.
Attachment #590791 -
Flags: ui-review?(bwinton)
Comment 12•11 years ago
|
||
On the left with Mark's patch added and on the right with my additional fix.
Comment 13•11 years ago
|
||
Comment on attachment 590791 [details] [diff] [review] New Fix Stealing this ui-review from bwinton
Attachment #590791 -
Flags: ui-review?(bwinton) → ui-review?(nisses.mail)
Comment 14•11 years ago
|
||
Comment on attachment 590791 [details] [diff] [review] New Fix Works great! Labels can become really long and widgets do no longer resize. Also tested in RTL.
Attachment #590791 -
Flags: ui-review?(nisses.mail) → ui-review+
Reporter | ||
Comment 15•11 years ago
|
||
Comment on attachment 590791 [details] [diff] [review] New Fix I didn't do a detailed review, but this looks like the right approach, it's using <grid>, and we should have done that all along. Thanks!
Attachment #590791 -
Flags: feedback+
Comment 16•11 years ago
|
||
Perhaps we should file a Toolkit bug on the resizing widgets? That seems wrong in general...
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #590791 -
Flags: approval-comm-beta?
Attachment #590791 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 17•11 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/8d6d172e7a91
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 13.0
Assignee | ||
Updated•11 years ago
|
Attachment #590791 -
Flags: approval-comm-beta?
Attachment #590791 -
Flags: approval-comm-beta+
Attachment #590791 -
Flags: approval-comm-aurora?
Attachment #590791 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 18•11 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/e265914697e8 http://hg.mozilla.org/releases/comm-beta/rev/6fa3d8b42ade
status-thunderbird11:
--- → fixed
status-thunderbird12:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•