Closed Bug 636021 Opened 9 years ago Closed 9 years ago

Nit: no 'let' in ensureMPUnlocked

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: rnewman, Assigned: rnewman)

Details

(Whiteboard: [fixed in fx-sync][fixed in services][qa-])

Attachments

(1 file)

Not sure how this got past code review. See attachment.
Attachment #514341 - Flags: review?(philipp)
Comment on attachment 514341 [details] [diff] [review]
Proposed patch. v1

>+    let sdr = Cc["@mozilla.org/security/sdr;1"].
>+              getService(Ci.nsISecretDecoderRing);

Nit: put the '.' on the next line and align it with the '['. See https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide#Operators
Attachment #514341 - Flags: review?(philipp) → review+
Pushed:

  http://hg.mozilla.org/services/fx-sync/rev/20c928c226d7

I also fixed another identical chunk of "[]." syntax elsewhere in util.js, from which I took my incorrect stylistic inspiration!

This should end up on m-c at some point; this printed a style warning to the error log during Sync setup. Merge bug already?
Whiteboard: [fixed in fx-sync]
Comment on attachment 514341 [details] [diff] [review]
Proposed patch. v1

Flagging for approval to get this into m-c. (If that's not the right path to take, my apologies!)
Attachment #514341 - Flags: approval2.0?
(In reply to comment #3)
> This should end up on m-c at some point; this printed a style warning to the
> error log during Sync setup. Merge bug already?

Since we're no longer immediately resolving bugs landed in fx-sync, we don't really need a merge bug.

(In reply to comment #4)
> Flagging for approval to get this into m-c. (If that's not the right path to
> take, my apologies!)

It's probably best to get approval before landing it anywhere, because if this gets minused, we'll have to back it out on fx-sync again.
Attachment #514341 - Flags: approval2.0? → approval2.0+
Merged to s-c: http://hg.mozilla.org/services/services-central/rev/89eb39f16253
Whiteboard: [fixed in fx-sync] → [fixed in fx-sync][fixed in services]
Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/89eb39f16253
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-sync][fixed in services] → [fixed in fx-sync][fixed in services][qa-]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.