636027 - self-serve is cumbersome for cancelling a whole build

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Paul Biggar]

Suppose I submit a tryserver build with all 9 (10?) platforms, but discover one of them fails. In that case, I'll want to cancel them all. Doing this is cumbersome.

Right now I would go to the self-serve page, and click 'cancel' (wait for page), then the back button (wait for page), then pick the next build and resume (in practice, I need to refresh the page periodically to know which builds I've cancelled).

A less cumbersome interface would be a button to cancel all builds for one revision, or making the 'cancel' button a link so I could middle-click all the cancels in turn.

self-serve is otherwise awesome, thanks.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Time was, you could command-click buttons and they would open in a new tab.  Not that that would fix this problem, but it'd make it a lot easier.  My solution now is to just open a bunch of copies of the buildapi page in tabs, and then click the proper button on each page.

Comment 2

[[e-mail] (:bhearsum)]

It should also be noted that self serve is not meant to be a full functioning interface, but rather a programmatic one that others can develop off of. (from http://atlee.ca/blog/2011/02/17/self-serve-builds/)

Comment 3

[Armen [:armenzg]]

Assigning to catlee for prioritization when he is back from holidays since he has been doing most of the work in this area.

Comment 4

[Paul Biggar]

(In reply to comment #2)
> It should also be noted that self serve is not meant to be a full functioning
> interface, but rather a programmatic one that others can develop off of. (from
> http://atlee.ca/blog/2011/02/17/self-serve-builds/)

Sure, but I think changing a button to a link is all that's required here.

Comment 6

[Chris AtLee [:catlee]]

I'll implement a method to cancel all builds for a revision in the API, and then expose that in the HTML.

Comment 7

[Chris AtLee [:catlee]]

Attachment: implete cancel by revision

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 545826 [details] [diff] [review]
implete cancel by revision

>diff --git a/buildapi/scripts/selfserve-agent.py b/buildapi/scripts/selfserve-agent.py
>+    def do_cancel_revision(self, message_data, message):
...
>+        for request in requests:
>+            brid = request.id
>+            log.info("Cancelling request %i", brid)
>+            if request.claimed_at:

A lot of this loop looks like do_cancel_request(). Perhaps it can be reused ?

Comment 9

[Chris AtLee [:catlee]]

Attachment: implement cancel by revision

totally right. that's what I get for late-night coding!

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 546201 [details] [diff] [review]
implement cancel by revision

lgtm

Comment 11

[(no longer active)]

Has this been deployed yet?  I don't see any change in the self-serve interface.

Comment 12

[Chris AtLee [:catlee]]

Yes, it's at the bottom of the per-revision page, e.g.

https://build.mozilla.org/buildapi/self-serve/mozilla-central/rev/5c4fe292a2404e2857acf1b7b9796d1d05790023