636083 - Don't send "Tagging started" email to r-d for dummy tag factory

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

I set skip_tag to True and reran the automation when tagging failed out on me. That worked great except that a second Tagging email was sent to r-d. I'd argue that that's more confusing than useful and should be prevented.

Conversely, the tagging complete mail didn't go to r-d, despite the FIXED resolution of bug 635510.

Comment 1

[Rail Aliiev [:rail]]

> Conversely, the tagging complete mail didn't go to r-d, despite the FIXED
> resolution of bug 635510.

That's expected. 

The "tag" builder ran 2 times for 4.0b12 build1. 

The first one failed. We don't send "failed" emails to r-d (mode='passing'). 

The second one (with releaseConfig['skip_tag'] = True) was dummy. Tag builder is not added to notify_builders in this case, see around this line:
http://hg.mozilla.org/build/buildbotcustom/file/dd7e3fa9d386/process/release.py#l530

Morphing the title. Patch is on the way.

Comment 2

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

To be tested in staging.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 514468 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/86c637c8f3e4

Comment 4

[Rail Aliiev [:rail]]

Tested in staging.