Closed Bug 636086 Opened 13 years ago Closed 13 years ago

build bustage when building with --disable-pango

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

patch v.1
843 bytes, patch
karlt
: review+
Details | Diff | Splinter Review
Attached patch patch v.1 — — Splinter Review 
When building disable pango, it looks like the code assumes android:


/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp: In member function ‘virtual void FontFamily::FindStyleVariations()’:
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:311: warning: comparison between signed and unsigned integer expressions
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:313: error: ‘gfxAndroidPlatform’ was not declared in this scope
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:313: error: ‘platform’ was not declared in this scope
Attachment #514420 - Flags: review?(karlt)
Attachment #514420 - Flags: review?(karlt) → review+
http://hg.mozilla.org/mozilla-central/rev/9d7024419b46
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: