Closed Bug 636086 Opened 11 years ago Closed 11 years ago

build bustage when building with --disable-pango

Categories

(Core :: Layout: Text and Fonts, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

Attached patch patch v.1Splinter Review
When building disable pango, it looks like the code assumes android:


/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp: In member function ‘virtual void FontFamily::FindStyleVariations()’:
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:311: warning: comparison between signed and unsigned integer expressions
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:313: error: ‘gfxAndroidPlatform’ was not declared in this scope
/builds/mozilla-central/gfx/thebes/gfxFT2Fonts.cpp:313: error: ‘platform’ was not declared in this scope
Attachment #514420 - Flags: review?(karlt)
Attachment #514420 - Flags: review?(karlt) → review+
http://hg.mozilla.org/mozilla-central/rev/9d7024419b46
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.