Closed
Bug 636091
Opened 13 years ago
Closed 13 years ago
check.py - buildduty helper program
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bear, Unassigned)
References
Details
(Whiteboard: [android][tegra])
Attachments
(1 file)
check.py -p /builds defaults to /builds -t tegra-001 if not given will scan all tegra-### dirs -r reset tegra -r is applied if the tegra is found to be online but an error.flg is present. check.py will remove the error.flg file
Reporter | ||
Updated•13 years ago
|
Attachment #514423 -
Flags: review?(aki)
Updated•13 years ago
|
Attachment #514423 -
Attachment mime type: text/x-python-script → text/plain
Comment 1•13 years ago
|
||
Comment on attachment 514423 [details] buildduty helper program This is very tegra-specific, but that's ok for now. We can either rename to check-tegra.py or make it more generic in the future. Will clientproxy detect that the flg file is removed and automatically do the right thing, or do you need to do something else? There may be some edge cases where this will cause some orange-, purple- or redness, but I'm not sure I'm going to be able to think of what those might be, so I'm not going to block on that. > global options, daemon, sutDialbackPort Is this left over from something? You don't seem to use Queue or current_process, but that probably doesn't hurt.
Attachment #514423 -
Flags: review?(aki) → review+
Reporter | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > Comment on attachment 514423 [details] > buildduty helper program > > This is very tegra-specific, but that's ok for now. > We can either rename to check-tegra.py or make it more generic in the future. > > Will clientproxy detect that the flg file is removed and automatically do the > right thing, or do you need to do something else? every cycle if the tegra is listed as active it will look to start the buildslave unless there is a flag file, so it's removal will automatically cause the next run to not block. > > There may be some edge cases where this will cause some orange-, purple- or > redness, but I'm not sure I'm going to be able to think of what those might be, > so I'm not going to block on that. > > > global options, daemon, sutDialbackPort > > Is this left over from something? You don't seem to use Queue or > current_process, but that probably doesn't hurt. Yea, this code was built up from other parts and the import was a last minute addition. It allows all the tegras to be checked at the same time instead of sequentially. I've removed them and also the two unneeded global references
Reporter | ||
Comment 3•13 years ago
|
||
committed changeset 1172:7fa62a04b0c8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•