636140 - browser_tapping.js failure

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 514473 [details] [diff] [review]
Patch


>+    // Hack the allowZoom getter since we want to observe events
>+    // for testing purpose even if it is a local tab
>+    gCurrentTab.__defineGetter__("allowZoom", function() {
>+      return true;
>+    });

Add a "See: ContentTouchHandler.handleEvent for 'TapUp'"  to the comment so it's easier to find the code that we need to work around

>+    setTimeout(runNextTest, 0);

Is this OK for devices? Might be too short. I guess we'll find out

r+ but add the comment

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> >+    // Hack the allowZoom getter since we want to observe events
> >+    // for testing purpose even if it is a local tab
> >+    gCurrentTab.__defineGetter__("allowZoom", function() {
> >+      return true;
> >+    });
> 
> Add a "See: ContentTouchHandler.handleEvent for 'TapUp'"  to the comment so
> it's easier to find the code that we need to work around

Will do on checkin.

> 
> >+    setTimeout(runNextTest, 0);
> 
> Is this OK for devices? Might be too short. I guess we'll find out
> 

Well, this is not really needed for the test to work but I have add it, just in case...

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c85ebbcb23c7

Comment 4

[Dão Gottwald [:dao]]

bugspam