636223 - "Clear Private Data" should disconnect Fennec from Firefox Sync

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Connect to a Firefox Sync account.
2. Press the "Clear Private Data" button in the Fennec prefs.
3. Wait for the next sync to occur.

Expected results: Fennec history is cleared; Fennec is disconnected from Sync.

Actual results: Fennec history is cleared initially, but Fennec is still connected to Sync, and the history is re-populated from the Sync server.

To prevent this, and to prevent any risk of wiping other computers' data via Sync, we should disconnect from Sync when you clear private data.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Disconnect from sync on "Clear Private Data."

When you clear private data, this will display a notification "Your Sync account has been removed. [Undo] [X]" just like when you press the Disconnect button manually.  (I think this is a good thing.)

Comment 2

[Madhava Enros [:madhava]]

yeah - I agree - the notification is good.

Comment 3

[Tony Chung [:tchung]]

will need tests.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 514565 [details] [diff] [review]
patch

The patch itself is fine, but we need to talk to a few more people before landing it.

Asking Madhava for feedback and Stuart too.

Comment 5

[Madhava Enros [:madhava]]

This makes sense to me, given that
1. clearing private data should undo your connection to your account (given the "wipe this browser clean of association to me" scenario)
2. we really don't want the clearing to propagate back to desktop

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 514565 [details] [diff] [review]
patch

mconnor and philikon also approved of this change in IRC.  Pushed the patch so we can start getting nightly coverage:
http://hg.mozilla.org/mobile-browser/rev/8cbaf82a125f

More feedback is still welcome, of course.

Comment 7

[Ayan Shah[:ashah]]

Verified on:
Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20100307
Firefox/4.0b13pre Fennec/4.0b6pre

Comment 8

[Ioana Chiorean]

https://litmus.mozilla.org/show_test.cgi?id=15206