Our compatibility numbers would look a little better if we filter out add-ons that are no longer offered on our site and in most cases are abandoned. With Firefox 4 approaching, I think it would be very useful to have a more realistic view of our work migrating developers. This is a patch for the compatibility report generator that filters out add-ons that have been marked as inactive by the developer, or admin-disabled by us. On a separate note: I'm not too well-versed in SQL, but it would appear that that query doesn't count add-ons that don't have an en-US translation. Shouldn't translations.locale = 'en-US' be translations.locale = addons.default_locale or something similar?
Attachment #514594 - Flags: review?(clouserw)
Comment on attachment 514594 [details] [diff] [review] Patch V1. Filters out disabled and inactive add-ons Looks fine to me. I don't know about the en-US thing - maybe the compat reporter was originally en-US only?
Attachment #514594 - Flags: review?(clouserw) → review+
I think the intended purpose of that condition is to get the en-US name of the add-on, but it's also (unintentionally, I think) discarding any add-ons that don't have en-US localizations. I assume there are at least a few of those in the top usage list. fligtar, do you know?
yes, it should be default locale.
OK, I'm lagniapping this bug then.
Comment on attachment 514663 [details] [diff] [review] Patch V2. With fixed locale bug I can r+ the code, but I didn't check that the output corresponds to what you want.
Attachment #514663 - Flags: review?(clouserw) → review+
(In reply to comment #4) > OK, I'm lagniapping this bug then. woah woah woah. since when do you use Louisiana French?
Fixed, r83157. There's still about a week to test if the changes are effective. (In reply to comment #6) > woah woah woah. since when do you use Louisiana French? That word has haunted me for a while and I /needed/ to use it in a sentence.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
I tested on allizom, but the page is giving me 0 add-ons for the Compatibility Report: https://addons.allizom.org/en-US/firefox/compatibility I'm not sure if this happened before this patch, but it's possible. I tested the modified query directly against the DB, and I did get correct results, so there doesn't appear to be a syntax or logic error there. Is there anything different in allizom that would make this report fail?
(In reply to comment #8) > I tested on allizom, but the page is giving me 0 add-ons for the Compatibility > Report: > https://addons.allizom.org/en-US/firefox/compatibility > > I'm not sure if this happened before this patch, but it's possible. I tested > the modified query directly against the DB, and I did get correct results, so > there doesn't appear to be a syntax or logic error there. > > Is there anything different in allizom that would make this report fail? The numbers are generated off a cron job and stored in a file on the FS, afaik. I don't know how often it runs.
It's working now: https://addons.allizom.org/en-US/firefox/compatibility The modified query now produces 794 add-ons instead of 776 due to the popular add-ons that were taken out due to being disabled. I can confirm that some popular disabled add-ons are no longer on the list, and some popular localized add-ons (dictionaries, mostly) now appear. The new percentages are pretty much the same, with -1% difference. One bug I noticed is that some names can appear with question marks instead of special characters, like: https://addons.allizom.org/en-US/firefox/addon/%E6%96%B0%E5%90%8C%E6%96%87%E5%A0%82-new-tong-wen-tang/ I don't think it's important to address this now. It can be fixed in the migration to Zamboni. Verified.
Status: RESOLVED → VERIFIED
Question marks? I think that's your fonts. It looks fine to me.
(In reply to comment #11) > Question marks? I think that's your fonts. It looks fine to me. This is in the compatibility page, in the detailed report that shows the full list of add-ons. Search for ???? and you'll see a link to the add-on I just pointed out.
Got it, yeah, we'll fix that up.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.