636275 - MMgc selftest alloc_loop_mmgc_viagc_far should call GCHeap::FreeNoProfile instead of GCHeap::Free()

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Description

[Ruchi Lohani]

Selftest added for bug# 580603 should call GCHeap::FreeNoProfile() instead of GCHeap::Free(). kProfile flag is not set while calling GCHeap::Alloc().

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Where is a good place to start to learn about the profiler?

I.e. what is typical way to exercise it, and/or how did you exercise it in this case to uncover this bug?

Or is there some information spit out from the shell from something I don't typically look at (like, um, —memstats) that I should have been looking at?

Comment 2

[Ruchi Lohani]

I found it while running selftests on a debugger build (profiler is enabled). One also needs to set the MMGC_PROFILE environment variable. There was an assert failure inside RecordDeallocation, this one:  GCAssert(info != NULL); as the corresponding allocation was never recorded (kProfile flag not set).

Comment 3

[Tommy Reilly]

cf https://bugzilla.mozilla.org/show_bug.cgi?id=491361

Comment 4

[Ruchi Lohani]

Attachment: Patch

Comment 5

[Lars T Hansen]

Comment on attachment 524116 [details] [diff] [review]
Patch

No misgivings per se; happy to go with Felix's opinion.

Comment 6

[Tamarin Bot]

changeset: 6165:5173895fc71b
user:      Lars T Hansen <[e-mail]>
summary:   Fix 636275 - MMgc selftest alloc_loop_mmgc_viagc_far should call GCHeap::FreeNoProfile instead of GCHeap::Free() (patch=rulohani, r=fklockii, sr=lhansen, push=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/5173895fc71b