636291 - Ctrl+Shift+C Shortcut key to open calendar is destructive "Mark all read"

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Bill Davidsen]

User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110221 Firefox/4.0b12pre SeaMonkey/2.1b3pre
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110221 Firefox/4.0b12pre SeaMonkey/2.1b3pre

Installing Lightning on Seamonkey (2.0 or 2.1b) the "Events and Tasks" drop down shows "Ctrl+Shift+C" as the shortcut key. This sequence marks all items in the current folder as read! This permanently ends the ability to read unread mail for those messages.

NOTE: this is a menu error, the shortcut key sequence shown in the menu is wrong, not the functioning of the shortcut. Users who don't recognize the shortcut as wrong and use it as suggested get unexpected results.



Reproducible: Always

Actual Results:  
Menu tells the user to use a destructive shortcut to open the calendar tab

Expected Results:  
Menu would offer correct information, or show no shortcut

A user found this in current release 2.0.11 and I verified it in 2.1b as well. I recognized the shortcut BEFORE I tried it, the user didn't.

I marked this as "critical" because it does cause loss of important information and is in the production Seamonkey. Please don't push this off as a Lightning bug, Seamonkey needs the calendar for any serious use.

Comment 1

[Philip Chee]

What does Thunderbird 3.3 use for Mark-All-Read?

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> What does Thunderbird 3.3 use for Mark-All-Read?

Shift+C.   SM should be using the same thing. (and not Ctrl+Shift+C)

On thunderbird windows I can't reproduce Ctrl+Shift+C as marking all messages.

I would think if this affected all lightning users that the problem would have surfaced prior to this. Does reproduce only on linux or Mac?  In safe mode/without lighting?


(affirming completeness in summaries is a good thing)

Comment 3

[Philip Chee]

Thunderbird fixed this in:
Bug 477091: shortcuts for opening calendar or tasks tab don't work, new shortcuts required.
<http://hg.mozilla.org/comm-central/rev/129da8379d42>

But nobody thought to tell us about this. :P

Comment 4

[Bill Davidsen]

(In reply to comment #2)
> (In reply to comment #1)
> > What does Thunderbird 3.3 use for Mark-All-Read?
> 
> Shift+C.   SM should be using the same thing. (and not Ctrl+Shift+C)
> 
SM has been using Ctrl-Shift keys for a long time, and please understand that the bug is not in the function, it's in the menu. The menu tells the users about a shortcut which does something destructive, and all that needs to be done is to take the shortcut hint off the menu, or change it to something which works. Only the "bad advice" is a problem.

> On thunderbird windows I can't reproduce Ctrl+Shift+C as marking all messages.
> 
It doesn't, I think it actually does pop a calendar tab.

> I would think if this affected all lightning users that the problem would have
> surfaced prior to this. Does reproduce only on linux or Mac?  In safe
> mode/without lighting?
> 
The shortcut is actually working correctly, but it's the WRONG shortcut. We just need to stop telling people to shoot themselves in the foot! Something like a recipe which specifies arsenic when it meant aspic, if you don't know it's dangerous it causes problems.

Comment 5

[Philip Chee]

critical=>major since Edit->Undo Mark All Read (CTRL-Z) is available.

Comment 6

[Philip Chee]

Untested suggestion:

/calendar/lightning/jar.mn:
% overlay chrome://lightning/content/messenger-overlay-sidebar.xul chrome://lightning/content/suite-overlay-sidebar.xul application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}

/calendar/lightning/content/suite-overlay-sidebar.xul:
    <keyset id="calendar-keys">
      <key id="openLightningKey"
           modifiers="shift"/>
    </keyset>

Would this be acceptable to the Calendar team?

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sounds good to me, but you'll probably have more luck just specifying the inner key in the xul file, i.e just

<key id="openLightningKey" modifiers="shift"/>

Comment 8

[Philip Chee]

While working on this I noticed that Lightning uses
CTRL-SHIFT-D to open the tasks tab, and
CTRL-D to create a new task.

Unfortunately this clashes with SeaMonkey which uses these shortcuts for Get New Messages, and Get New Messages for All Accounts.

Is ALT-D and ALT-SHIFT-D taken? Or do we just remove the shortcut keys for these two items?

Comment 9

[Bill Davidsen]

(In reply to comment #8)
> While working on this I noticed that Lightning uses
> CTRL-SHIFT-D to open the tasks tab, and
> CTRL-D to create a new task.
> 
> Unfortunately this clashes with SeaMonkey which uses these shortcuts for Get
> New Messages, and Get New Messages for All Accounts.
> 
> Is ALT-D and ALT-SHIFT-D taken? Or do we just remove the shortcut keys for
> these two items?

That was very much was I had in mind when I reported this bug, the error is that the menu suggests the wrong shortcut, why not just take the shortcut off the menu? Not that I have anything against ALT-C for calendar, but just taking the wrong info off the menu would solve the problem as far as I'm concerned.

This is like the menu which said Shift-Cntl-K ended a link, when in fact it started the spell checker. I reported that against 1.0.6 and it was fixed in 2.0b, finally. There's no need to change anything but delete the bad info on the menu.

Comment 10

[Philip Chee]

Bill, removing the visual indication from the menu doesn't remove the shortcut which will still be active. I am proposing removing the shortcut(s) as well.

Comment 11

[Bill Davidsen]

(In reply to comment #10)
> Bill, removing the visual indication from the menu doesn't remove the shortcut
> which will still be active. I am proposing removing the shortcut(s) as well.

But the shortcut is USEFUL! It's the shortcut to "mark all read" it just has nothing to do with calendar. All we need to do is stop telling people to do the wrong thing for calendar, the shortcut works exactly as intended. The shortcut to the function people have been using for years is fine as is.

Why is this so hard to see? There is bad information in the menu, take it out. Then people don't go to the menu and decide to use the "faster way" to get a calendar. The error is in the menu, it should be fixed there, defining a new shortcut for calendar is optional.

Comment 12

[Philip Chee]

Sorry I meant removing the *Lightning* shortcut. At the moment the SeaMonkey CTRL-SHIFT-C wins out but under certain circumstances e.g. if you are using KeyConfig to reorder your shortcut keys, the lightning version of CTRL-SHIFT-C might win out. I'm thinking of removing both the visual indication in the Lightning menu as well as the underlying Lightning shortcut so that nothing interferes with the native SeaMonkey shortcut. Sorry for the confusion.

Comment 13

[Karsten Düsterloh]

> I'm thinking of removing both the visual indication in the Lightning menu as
> well as the underlying Lightning shortcut so that nothing interferes with the
> native SeaMonkey shortcut.

That seems to be the most plausible course, yes.

Comment 14

[Philip Chee]

Attachment: Patch v1.0 Remove shortcuts when in SeaMonkey.

> Karsten Düsterloh      2011-03-01 23:21:39 PST
> 
>> I'm thinking of removing both the visual indication in the Lightning menu as
>> well as the underlying Lightning shortcut so that nothing interferes with the
>> native SeaMonkey shortcut.
> 
> That seems to be the most plausible course, yes.

Instead of desperately chasing down increasing rare unused shortcut keys in SeaMonkey MailNews, I'll just remove the main Lightning shortcuts when installed in SeaMonkey. And even if I fix the shortcuts in en-US it's likely one or more SeaMonkey locales will still have this problem.

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 516264 [details] [diff] [review]
Patch v1.0 Remove shortcuts when in SeaMonkey.

r=philipp

Comment 16

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6f848212dca4