63635 - need "Mark" toolbar icon (only visible when reading news)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

4x had this, I miss it.

Comment 1

[jglick]

Do we need a toolbar button for this or would a menu item be sufficient?

Comment 2

[(not reading, please use [e-mail] instead)]

we already have it in the menus:  "Message | Mark | ..." 

I'd like to have a toolbar button.

marking as read is pretty common in news.

adding laurel to the cc list for her opinion.

accepting.

Comment 3

[jglick]

Replacing the "Delete" button like 4.x?

cc'ing Marlon since icons for Classic and Modern will be needed.

Comment 4

[(not reading, please use [e-mail] instead)]

yes, replacing delete would be good.  (I have a bug to remove delete when
reading news, so I could fix both in one fell swoop.)

Comment 5

[laurel]

I agree with the mark button.

Also (side issue) the Biggee for newsreaders is a Mark Newsgroup Read context 
menu item which would allow marking read without having to open/download the 
headers -- 4.x has this (select group in folder pane, right click to get context 
menu).  This context item may already be logged in an existing bug, I don't 
know.

Comment 6

[laurel]

*** Bug 41311 has been marked as a duplicate of this bug. ***

Comment 7

[timeless]

would someone please publish the urls mentioned in bug 41311 in mozilla.org or 
somewhere that mortals can view?

Comment 8

[(not reading, please use [e-mail] instead)]

fix in hand, bienvenu is reviewing.

I've got icons for the classic skin already.  I just need them for modern.

my fix has some crappy placeholder icons (that I horked up) until I get the real
deal from marlon.

Comment 9

[(not reading, please use [e-mail] instead)]

also, my fix hides the delete toolbar when reading news, and hides the mark
toolbar when reading mail.   just like 4.x.

laurel's side issue is not addressed.  we'll need a new bug for that.

"Also (side issue) the Biggee for newsreaders is a Mark Newsgroup Read context 
menu item which would allow marking read without having to open/download the 
headers -- 4.x has this (select group in folder pane, right click to get context 
menu).  This context item may already be logged in an existing bug, I don't 
know."

Comment 10

[jglick]

timeless, sorry the url in dup bug is internal. It is invalid now anyway. All 
future specs will now be on mozilla/mailnews.  Marlon, our graphic artist, will 
be created the "Mark" icon needed for this bug to match the new Modern look.  
Marlon, any progress?

Comment 11

[(not reading, please use [e-mail] instead)]

I talked to marlon.  he said some time next week or the week after that.

until then, I'm going to land my horrible place holder icons.

classic skin has icons, so only modern will look bad.

Comment 12

[marlon bishop]

acknowledged

Comment 13

[(not reading, please use [e-mail] instead)]

fixed.  there are couple new bugs exposed by my checkin, I'll log them now.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED, the purple-ground Mark icon is in ;-)

Comment 15

[Pratik]

I feel even the message display window should show the new "Mark" tool bar icon.
Currently, double clicking the news message and opening in a separate pane,
shows the "Delete" icon instead of "Mark". Is this a different bug?

Comment 16

[jglick]

You mean viewing a news posting in the Standalone window? Yes, the "Mark" icon 
should replace the "Delete" icon there also.  Up to Seth if he wants a new bug 
filed for that?

Comment 17

[(not reading, please use [e-mail] instead)]

I'll go open a new bug on the "stand alone message window" problem.

I've got a fix for it.  I got to remember to use that stand alone message window.