toolbar buttons should not use native GTK look on :hover when using a lightweight theme

RESOLVED INVALID

Status

()

Toolkit
Themes
RESOLVED INVALID
7 years ago
3 months ago

People

(Reporter: pascalc, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Created attachment 514681 [details]
before/after screenshot

When using a persona, Firefox and other toolkit applications should not show GTK-styled toolbar icons  on :hover state. The use of a background image in the Chrome is not a normal behaviour for GTK applications and therefore the :hover state of icons looks very bad because they don't blend with the persona.

We should do like we do on Windows and use a transparency, I have a patch for that.

Attaching a screenshot showing Firefox 4 trunk with different icons hovered with and without my patch.
(Reporter)

Comment 1

7 years ago
Created attachment 514693 [details] [diff] [review]
proposed patch

FYI, I tested this patch with a variety of personas on both Firefox and Thunderbird and it looks much better for both applications.
Assignee: nobody → pascalc
Attachment #514693 - Flags: review?(dao)
(Reporter)

Comment 2

7 years ago
(this is the first time I use Mercurial Queues to generate the patch, hopefully it is correct! :) )
(Reporter)

Comment 3

7 years ago
Created attachment 514762 [details] [diff] [review]
updated patch

Updated patch with the following changes:
- Do not restyle the "add tab" button, we already style it individually
- Do not restyle the tab button close widget, it uses specific margins and should probably be replaced by an image when using personas (new bug?)
- syntax changes for rule values to follow the file code style
Attachment #514693 - Attachment is obsolete: true
Attachment #514762 - Flags: review?(dao)
Attachment #514693 - Flags: review?(dao)
Comment on attachment 514762 [details] [diff] [review]
updated patch

tabs-newtab-button is browser-specific and doesn't belong in toolbarbutton.css. You should probably put this in browser.css.
Attachment #514762 - Flags: review?(dao) → review-
(Reporter)

Updated

4 years ago
Assignee: pascalc → nobody
(Reporter)

Updated

3 months ago
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.