636354 - toolbar buttons should not use native GTK look on :hover when using a lightweight theme

Status: RESOLVED INVALID

(Toolkit :: Themes, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: before/after screenshot

When using a persona, Firefox and other toolkit applications should not show GTK-styled toolbar icons  on :hover state. The use of a background image in the Chrome is not a normal behaviour for GTK applications and therefore the :hover state of icons looks very bad because they don't blend with the persona.

We should do like we do on Windows and use a transparency, I have a patch for that.

Attaching a screenshot showing Firefox 4 trunk with different icons hovered with and without my patch.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: proposed patch

FYI, I tested this patch with a variety of personas on both Firefox and Thunderbird and it looks much better for both applications.

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

(this is the first time I use Mercurial Queues to generate the patch, hopefully it is correct! :) )

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: updated patch

Updated patch with the following changes:
- Do not restyle the "add tab" button, we already style it individually
- Do not restyle the tab button close widget, it uses specific margins and should probably be replaced by an image when using personas (new bug?)
- syntax changes for rule values to follow the file code style

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 514762 [details] [diff] [review]
updated patch

tabs-newtab-button is browser-specific and doesn't belong in toolbarbutton.css. You should probably put this in browser.css.