63649 - [BeOS] nsAppShell::DispatchNativeEvent() implemented

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Makoto Hamanaka]

I implemented nsAppShell::DispatchNativeEvent().

I thought that nsAppShell::DispatchNativeEvent() should do one iteration of 
the event loop, while do not count timer event as an iteration.

Though I'm not so confident about the code, the 'Security Warning' dialog
seems to be working as expected when I submit a form though network.

review required.

Comment 1

[Makoto Hamanaka]

Attachment: patch to widget/src/beos/nsAppShell.cpp

Comment 2

[Yannick Koehler]

I'll review it.  While the result may not be the ideal solution, if it works 
for some part and not for other it would still be better than now where it 
doesn't work anywhere ;-)

Comment 3

[timeless]

sprintf and true should have NSPR counterparts which we would like people to 
use.

Comment 4

[Makoto Hamanaka]

timeless, 
Thank you for your suggestions. Though, should we so strict in these BeOS specific code 
where we have to use BeOS API which we can't replace with NSPR counterparts?

Comment 5

[timeless]

I'm pretty sure you are supposed to even in BeOS code fragments, true and the 
pr true are compatible, and sprintf is probably more dangerous than the pr 
printf.  

cc scc,brendan to explain

Comment 6

[Yannick Koehler]

*** Bug 64018 has been marked as a duplicate of this bug. ***

Comment 7

[Yannick Koehler]

what's the NSPR equivalent of sprintf?

Comment 8

[Brendan Eich [:brendan]]

http://lxr.mozilla.org/mozilla/source/nsprpub/pr/include/prprf.h purveys several
variations on BSD-style snprintf.

/be

Comment 9

[cls]

Attachment: Updated patch that uses PR_snprintf, PR_TRUE and puts DEBUG ifdefs around printf() warnings

Comment 10

[cls]

The patch with the XP updates has been checked in.

Comment 11

[cls]

*** Bug 64018 has been marked as a duplicate of this bug. ***