63665 - Fix shutdown leaks in nsTraceRefcnt

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This morning I checked in a fix (see bug 61243) so that nsTraceRefcnt deletes
its hashtables on shutdown.  However, they still don't have the correct alloc
ops, so the things owned by the hashtables are still leaked.

I think I have a fix for the correct alloc ops, although I'd like to test it a
bit more before I consider it ready.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: first draft of fix

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: better fix

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This has the side effect of adding, after nsTraceRefcnt has been shut down,
information about all objects to refcount logs rather than just the ones
being logged.  It's annoying, but perhaps we need a better incentive to
clean those things up...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the side effect I mentioned is actually more likely from the earlier fix
that's already in.  If it's annoying enough, I could try to figure out which
thing I need to leak to fix it, although it really shouldn't be much of a problem...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Since I really need to get the stuff in bug 66159 tested on Windows and Mac,
moving this to mozilla 0.9.1

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Pushing out again.  I'll try to land this early in 0.9.2.  Really.  (I should
have time this time around.)

Comment 7

[timeless]

*** Bug 199059 has been marked as a duplicate of this bug. ***

Comment 8

[timeless]

Attachment: attachment 22181 w/ conflict resolved

Comment 9

[timeless]

Comment on attachment 118379 [details] [diff] [review]
attachment 22181 [details] [diff] [review] w/ conflict resolved

this works, would you please check it in?

Comment 10

[Alec Flett]

Comment on attachment 118379 [details] [diff] [review]
attachment 22181 [details] [diff] [review] w/ conflict resolved

sr=alecf

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-03-25 06:53 PST.