636711 - Using JSString * for JSScript::filename

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, enhancement)

Description

[Igor Bukanov]

+++ This bug was initially created as a clone of Bug #632253 +++

Currently JSScript::filename is const char * stored in a specialized hash that implements its own GC-marking machinery. We should try to replace that with JSString * to simplify code.

Comment 1

[Brendan Eich [:brendan]]

We don't need uint16 chars for filenames and that would be a loss for debugging and needless decimation code for diagnostics.

More, the script filename table shares filename strings aggressively and keeps track of prefixes for the system bit. Blake says we still need that bit, and the space savings were significant (see bug 127130). Please do not rip this stuff out lightly.

/be

Comment 2

[Jeff Walden [:Waldo]]

That's an NSS/SSL bug -- probably not the one you meant to post, I'm guessing?

Comment 3

[Brendan Eich [:brendan]]

Oops, that was the attachment id (copied from the cvs log message): attachment 127130 [details] for bug 208030.

/be

Comment 4

[Bryan Thrall [:bthrall]]

Based on comment 1, we aren't going to use JSString for JSScript::filename