636738 - [traceback] IntegrityError on the recs URLs

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P2)

Description

[Wil Clouser [:clouserw]]

It looks like we're getting dupes on UUIDs? eg. /en-US/firefox/discovery/recs

Traceback (most recent call last):

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 109, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/views/decorators/csrf.py", line 39, in wrapped_view
   resp = view_func(*args, **kwargs)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/views/decorators/csrf.py", line 52, in wrapped_view
   return view_func(*args, **kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 43, in wrapper
   return f(request, *args, **kw)

 File "/data/amo_python/www/prod/zamboni/apps/discovery/views.py", line 146, in recommendations
   synced = get_synced_collection(addon_ids, token)

 File "/data/amo_python/www/prod/zamboni/apps/discovery/views.py", line 178, in get_synced_collection
   c.token_set.create(token=token)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/fields/related.py", line 425, in create
   return super(RelatedManager, self.db_manager(db)).create(**kwargs)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/manager.py", line 138, in create
   return self.get_query_set().create(**kwargs)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/query.py", line 353, in create
   obj.save(force_insert=True, using=self.db)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/base.py", line 454, in save
   self.save_base(using=using, force_insert=force_insert, force_update=force_update)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/base.py", line 547, in save_base
   result = manager._insert(values, return_id=update_pk, using=using)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/manager.py", line 195, in _insert
   return insert_query(self.model, values, **kwargs)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/query.py", line 1401, in insert_query
   return query.get_compiler(using=using).execute_sql(return_id)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 786, in execute_sql
   cursor = super(SQLInsertCompiler, self).execute_sql(None)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 730, in execute_sql
   cursor.execute(sql, params)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute
   return self.cursor.execute(query, args)

 File "/usr/lib/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
   self.errorhandler(self, exc, value)

 File "/usr/lib/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
   raise errorclass, errorvalue

IntegrityError: (1062, "Duplicate entry '97ccc0c7-0ff2-418d-81be-ff18c181bf48' for key 2")

Comment 1

[Jeff Balogh (:jbalogh)]

This is already on next with https://github.com/jbalogh/zamboni/commit/01157339.

Comment 2

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/aa8bc7d

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

This was pushed to prod, right?  (The traceback-deluge mail seems to have subsided.)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

A non-answer is an answer.

Verified FIXED, as I haven't seen these in my tracebacks, since.