636744 - InlineWriteBarrierGuardedTrap need to assert more aggressively that container is a GCObject

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Description

[Tommy Reilly]

Having the asserts buried under BarrierActive() isn't good.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

(swipe)

This should be easy to implement; the "hard" part is doing the appropriate sandbox builds (including player land).

(I'll unassign myself if I discover that I shouldn't have put sarcasm-quotes around the word "hard" above. :)

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: unbury barrier asserts.

Comment 3

[Lars T Hansen]

Fix it or move it to Anza.

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 516607 [details] [diff] [review]
unbury barrier asserts.

This looks like it will survive ATS runs.  Lets get it in there!

Comment 5

[Tamarin Bot]

changeset: 6341:60ea629f807a
user:      Felix S Klock II <[e-mail]>
summary:   Bug 636744: unbury barrier asserts (r=treilly, sr=lhansen).

http://hg.mozilla.org/tamarin-redux/rev/60ea629f807a

Comment 6

[Felix S. Klock II [:pnkfelix, :fklock]]

(whoops, still need to push to tr-serrano)

Comment 7

[Felix S. Klock II [:pnkfelix, :fklock]]

Pushed to TR-serrano rev 6281:c464e6c2dcbc

http://asteam.corp.adobe.com/hg/tamarin-redux-serrano/rev/c464e6c2dcbc