636786 - Army of Awesome landing page doesn't validate

Status: RESOLVED FIXED

(support.mozilla.org :: Army of Awesome, task, P4)

Description

[Erik Rose [:erik][:erikrose]]

Illegally empty attrs, alleged divs inside spans. Kind of embarrassing: http://validator.w3.org/check?uri=http%3A%2F%2Fsupport.mozilla.com%2Farmy-of-awesome&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 1

[James Socol [:jsocol, :james]]

AoA is a low priority right now.

Comment 2

[Clauber Stipkovic [:cstipkovic]]

I'm working on this bug :)

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Clauber Stipkovic from comment #2)
> I'm working on this bug :)

Awesome! Let me know if you have any questions or need any help at all.

Comment 4

[Clauber Stipkovic [:cstipkovic]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #3)
> (In reply to Clauber Stipkovic from comment #2)
> > I'm working on this bug :)
> 
> Awesome! Let me know if you have any questions or need any help at all.

Hey r1cky :)

Tks for the message!

Comment 5

[Clauber Stipkovic [:cstipkovic]]

Pull request sended:

- https://github.com/mozilla/kitsune/pull/587

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Removing mentor status for now as this page is going through changes with the redesign.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

This is still an issue after the redesign. Adding mentor bits back.

Comment 8

[Anush [:anushbmx]]

I see the Error is due to missing alt tags in <img>, I am adding alt tags for missing images in following rules

* For user Profile image alt = User name
* For Loading & other UX images alt = Their Meaning

Comment 9

[Anush [:anushbmx]]

PR https://github.com/mozilla/kitsune/pull/1949

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Anush is working on this.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Landed that on master:
https://github.com/mozilla/kitsune/commit/11a9558f1a272f96eea4c6c98091c7f709f7b2e3

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

Deployed and most of the errors are gone. 3 left though:
http://validator.w3.org/check?uri=http%3A%2F%2Fsupport.mozilla.com%2Farmy-of-awesome&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 13

[Anush [:anushbmx]]

Those 3 errors are due to the empty element made for the popup box, the only way to avoid is by giving it with some value. May be some placeholder.

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

Anush, I think you can try removing the attributes and make sure the code handles it. Otherwise, we might need placeholders in them like you said.

Comment 15

[Anush [:anushbmx]]

My suggestion is to go with placeholder and here are my views.

Place Holder for images : http://placehold.it/
For text : Army Of Awesome 
For Datetime : Time strap.

Comment 16

[Anush [:anushbmx]]

Any views over this

(comment #15)
> My suggestion is to go with placeholder and here are my views.
> 
> Place Holder for images : http://placehold.it/
> For text : Army Of Awesome 
> For Datetime : Time strap.

Comment 17

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Are you still working on this?

Comment 18

[Anush [:anushbmx]]

@andrew Sorry I was on a break from mozilla activities due to university works, will get it fixed soon.

Is every one ok comment #15

Comment 19

[Anush [:anushbmx]]

PR with suggestions from comment #15

https://github.com/mozilla/kitsune/pull/2222

Comment 20

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d023c16b06f4de06296fd9ca11a8eba03bc5b7d8

Comment 21

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.