636824 - gfx driver admin tool should set null guids

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Justin Scott [:fligtar]]

if the guid field is left empty, the GUID should be NULL, not blank.

Comment 1

[Justin Scott [:fligtar]]

Why is this 4.x? It's a pain to write/get IT to run SQL to blocklist graphics drivers, which is what we have to do while this bug exists.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> Why is this 4.x? It's a pain to write/get IT to run SQL to blocklist graphics
> drivers, which is what we have to do while this bug exists.

Blocklisting doesn't happen very often, and when it does adding it to the list is not the bottleneck (see all the current open bugs waiting on someone to make a decision).  We've had IT running SQL for months (years?) and it's been effective.  This isn't a Q1 goal, but is competing for time with bugs that are Q1 goals.

Comment 3

[Justin Scott [:fligtar]]

Effective is not how I would describe bug 636254. I would describe it as a colossal waste of my time.

Comment 4

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/19f7f7a 

Colossally waste time no more!

Comment 5

[krupa raj[:krupa]]

gfx items with no GUIDs have guid field set to 'None' (fligtar said he is fine with it)

verified @ https://addons-next.allizom.org/en-US/firefox/blocked/

Comment 6

[krupa raj[:krupa]]

Attachment: post-fix screenshot