636842 - Expose detailed add-on details in reports on the dashboard

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Result Dashboard, enhancement)

Description

[Aaron Train [:aaronmt]]

It would be useful to take the detailed reports generated with the additions from bug 636773 and expose them to the dashboard.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, would you mind attaching the code you have for the endurance tests to that bug? That would help to get this enhancement implemented.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

And before bug 636773 is fixed we can make use or our persisted object implemented by bug 634567.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add add-ons details to endurance report. v1

Example can currently be seen here: http://mozmill.blargon7.com/#/endurance/report/66e0fb6bd5645ddae0ee8e21d0008672

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 521788 [details] [diff] [review]
Add add-ons details to endurance report. v1

>+        <th style="vertical-align:top">Add-ons:</th>

This style we should make default for th in the report details page.

>+          <ul style="margin:0">

So you are using margin:0 to hide the list style image? Use 'list-style-image: none;' to really disable it.

Otherwise move all style definitions if possible to main.css.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Add add-ons details to endurance report. v1.1

(In reply to comment #4)
> Comment on attachment 521788 [details] [diff] [review]
> Add add-ons details to endurance report. v1
> 
> >+        <th style="vertical-align:top">Add-ons:</th>
> 
> This style we should make default for th in the report details page.

Done.

> >+          <ul style="margin:0">
> 
> So you are using margin:0 to hide the list style image? Use 'list-style-image:
> none;' to really disable it.
> 
> Otherwise move all style definitions if possible to main.css.

Done.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 521794 [details] [diff] [review]
Add add-ons details to endurance report. v1.1

>+  padding:0px;

nit no unit necessary here.

>+        <td><ul class="addons"><li>Extensions:

The <li> should be on its own line.

I will do those minor tweaks right before the checkin. Thanks for taking that so quickly.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
https://github.com/whimboo/mozmill-dashboard/commit/a40990117d6168c6d696c747eb21bf47bcff696c