npnul32.rc should not depend on afxres.h

VERIFIED FIXED

Status

()

Core
Plug-ins
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

18 years ago
Removing the dependency makes it easier for mozilla to build w/o MFC which we 
are trying to do.
(Assignee)

Comment 1

18 years ago
Created attachment 21263 [details] [diff] [review]
remove dependency on afxres.h
(Assignee)

Comment 2

18 years ago
av: please review this.
Assignee: av → timeless
Keywords: approval, patch, review

Comment 3

18 years ago
Right, see no reason to depend on MFC. r=av
(Assignee)

Comment 4

18 years ago
Created attachment 21309 [details] [diff] [review]
corrected patch.
(Assignee)

Comment 5

18 years ago
Someone was cheating and using MFC to include the defines from winresrc.h

This version builds.

Comment 6

18 years ago
r=leaf, i'm not sure if this counts as being in the ``windows build system,''
though, since it's a non-makefile.win/config file. Should still get an sr.

Comment 7

18 years ago
sr=syd
(Assignee)

Comment 8

18 years ago
fix checked in, sr=syd.
fwiw, the include chain is mfc\afxres.h=>mfc\winres.h=>winresrc.h
dialog constants are defined in that last file.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
(Assignee)

Comment 9

18 years ago
something about bugzilla.
Status: RESOLVED → REOPENED
(Assignee)

Comment 10

18 years ago
Resolving _FIXED_
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

18 years ago
Created attachment 23824 [details] [diff] [review]
clean out useless apstudio entries

Comment 12

18 years ago
verified fix was checked in 1.4 version.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.