Closed Bug 636871 Opened 9 years ago Closed 9 years ago

final verification sent email to r-d on failure

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhford, Assigned: rail)

References

Details

Attachments

(1 file)

This email caused confusion during the 4.0 beta 12 push.  I was under the impression that only passing email should be forwarded to r-d.



From: 	release@mozilla.com
To: 	release-drivers@mozilla.org, release@mozilla.com
Subject: 	[release] Firefox 4.0b12 build1: failed at final_verification
Date: 	Fri, 25 Feb 2011 15:08:34 -0800


final_verification failed for Firefox 4.0b12 build1

-buildbot
log snippet:

2011-02-25 15:08:29-0800 [Broker,18541,10.2.71.177] <RemoteShellCommand '['bash', 'final-verification.sh', 'moz20-firefox-linux.cfg', 'moz20-firefox-linux64.cfg', 'moz20-firefox-mac64.cfg', 'moz20-firefox-win32.cfg']'> rc=1
2011-02-25 15:08:29-0800 [-] closing log <buildbot.status.builder.LogFile instance at 0x231ee80c>
2011-02-25 15:08:30-0800 [-] Pulse <buildbotcustom.status.pulse.PulseStatus instance at 0x2749cc4c>: Initiating push of 1 events
2011-02-25 15:08:30-0800 [-] releaseLocks(<buildbotcustom.steps.base.C instance at 0x1d26882c>): []
2011-02-25 15:08:30-0800 [-]  step 'final_verification' complete: failure
2011-02-25 15:08:30-0800 [-]  <Build release-mozilla-central-final_verification>: build finished
2011-02-25 15:08:30-0800 [-] Pulse <buildbotcustom.status.pulse.PulseStatus instance at 0x2749cc4c>: Sent 1 events in 0.16 seconds
2011-02-25 15:08:34-0800 [-] sending mail (118000 bytes) to ['tinderbox-daemon@tinderbox.mozilla.org']
2011-02-25 15:08:34-0800 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x22157b8c>
2011-02-25 15:08:34-0800 [-] sending mail (372 bytes) to ['release@mozilla.com', 'release-drivers@mozilla.org']
2011-02-25 15:08:34-0800 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x1442fcac>
Assignee: nobody → rail
Priority: -- → P2
Hardware: x86_64 → x86
Attached patch buildbotcustomSplinter Review
It was a fallout of bug 631539. Instead of using an explicit copy of releaseConfig['AllRecipients'] list I used implicit reference to it. 

The following code changes the value of releaseConfig['AllRecipients'] which is used in MailNotifier.

    tagging_started_recipients = releaseConfig['AllRecipients']
    if not releaseConfig.get('skip_tag'):
        tagging_started_recipients.extend(releaseConfig['PassRecipients'])


The attached patch should fix this bug.
Attachment #515251 - Flags: review?(catlee)
Attachment #515251 - Flags: review?(catlee) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.