636871 - final verification sent email to r-d on failure

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

This email caused confusion during the 4.0 beta 12 push.  I was under the impression that only passing email should be forwarded to r-d.



From: 	[e-mail]
To: 	[e-mail], [e-mail]
Subject: 	[release] Firefox 4.0b12 build1: failed at final_verification
Date: 	Fri, 25 Feb 2011 15:08:34 -0800


final_verification failed for Firefox 4.0b12 build1

-buildbot

Comment 1

[Rail Aliiev [:rail]]

log snippet:

2011-02-25 15:08:29-0800 [Broker,18541,10.2.71.177] <RemoteShellCommand '['bash', 'final-verification.sh', 'moz20-firefox-linux.cfg', 'moz20-firefox-linux64.cfg', 'moz20-firefox-mac64.cfg', 'moz20-firefox-win32.cfg']'> rc=1
2011-02-25 15:08:29-0800 [-] closing log <buildbot.status.builder.LogFile instance at 0x231ee80c>
2011-02-25 15:08:30-0800 [-] Pulse <buildbotcustom.status.pulse.PulseStatus instance at 0x2749cc4c>: Initiating push of 1 events
2011-02-25 15:08:30-0800 [-] releaseLocks(<buildbotcustom.steps.base.C instance at 0x1d26882c>): []
2011-02-25 15:08:30-0800 [-]  step 'final_verification' complete: failure
2011-02-25 15:08:30-0800 [-]  <Build release-mozilla-central-final_verification>: build finished
2011-02-25 15:08:30-0800 [-] Pulse <buildbotcustom.status.pulse.PulseStatus instance at 0x2749cc4c>: Sent 1 events in 0.16 seconds
2011-02-25 15:08:34-0800 [-] sending mail (118000 bytes) to ['[e-mail]']
2011-02-25 15:08:34-0800 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x22157b8c>
2011-02-25 15:08:34-0800 [-] sending mail (372 bytes) to ['[e-mail]', '[e-mail]']
2011-02-25 15:08:34-0800 [-] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x1442fcac>

Comment 2

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

It was a fallout of bug 631539. Instead of using an explicit copy of releaseConfig['AllRecipients'] list I used implicit reference to it. 

The following code changes the value of releaseConfig['AllRecipients'] which is used in MailNotifier.

    tagging_started_recipients = releaseConfig['AllRecipients']
    if not releaseConfig.get('skip_tag'):
        tagging_started_recipients.extend(releaseConfig['PassRecipients'])


The attached patch should fix this bug.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 515251 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/5647320d85b1