If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

/toolkit/components/prompts/test/*: remove extra ok() calls

RESOLVED WONTFIX

Status

()

Toolkit
General
--
minor
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
mozilla2.0
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Moving part that matters of bug 636197 patch Av2 here.
(Assignee)

Comment 1

7 years ago
Created attachment 515544 [details] [diff] [review]
(Av1) Do it, Make prompt_common.js logs more explicit, Remove redundant selectionTest in test_bug620145.html

Unexpected ok() are confusing log readers and bloating results.
Attachment #515544 - Flags: review?(dolske)
Exactly how are these calls "confusing log readers"?
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> Exactly how are these calls "confusing log readers"?

"Shared" checks (repeatedly) logged as (implicit) in-test checks, Unexpected (redundant) start information.
Comment on attachment 515544 [details] [diff] [review]
(Av1) Do it, Make prompt_common.js logs more explicit, Remove redundant selectionTest in test_bug620145.html

Oh, you mean _people_ reading logs?

No, not interested in optimizing that case.
Attachment #515544 - Flags: review?(dolske) → review-
As I said in the other bug, these kinds of test changes are a waste of time.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.