637335 - Jar files fail hash check on Win XP

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Tracy Walker [:tracy]]

Seen with 1.1.pre5 on Fx4beta11

Feedback button is unresponsive, Also can't get any notifications to fire, not even Dummy Popup.

Comment 1

[Jono Xia]

Trying to replicate.

I can click the Feedback button and see the menu, but when I get the All Your Studies window, it says "Loading, please wait..." forever.  (Tracy, is this the same behavior you saw, or is it different?)

I, too, can't get Dummy Popup or any notifications to fire.

The study_base_classes.jar code loads, but none of the experiment modules do (not present in either popup menu on the debug page).

This is on WinXP with Fx4b12 and TP1.1pre5.

Comment 2

[Jono Xia]

Relevant section from my error log:

2011-03-01 17:14:46	TestPilot.Loader     INFO	Attempting to verify jarfile vs hash = d534b22b220bf473463d0874f3f57a0d471db95a9b0d5cd40ffff2cd5b309d14
2011-03-01 17:14:46	TestPilot.Loader     WARN	Bad JAR file, doesn't match hash: d534b22b220bf473463d0874f3f57a0d471db95a9b0d5cd40ffff2cd5b309d14
2011-03-01 17:14:46	TestPilot.Loader     WARN	Error in saving jar file: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://testpilot/modules/lib/securable-module.js -> resource://testpilot/modules/jar-code-store.js :: <TOP_LEVEL> :: line 161"  data: no]


This happens for each experiment file.  They all fail their hash consistency check; then test pilot considers them corrupted and attempts to delete them but the attempt to delete the file also fails. (line 161 is  jarFile.remove(false); )

So there's three problems: First that the hash checks are failing; second that the file.remove() is failing; third that Test Pilot doesn't recover gracefully from a situation like this and tell the user something like "there are no experiments to run right now".

This is a hard blocker to release of 1.1.

Comment 3

[Jono Xia]

Downgraded to TP 1.0.3 on the same profile/same computer/same firefox.  Cleared error file and corrupted jar files.  Tried again.

Still has the exact same problem.  I suspect that the culprit is not changes in TP 1.1pre5, but is either something we did on the server side, or else a change to Firefox in b11.

Comment 4

[Jono Xia]

Yup, same thing is happening with a brand new profile using the built-in feedback extension.  Something seems to be going wrong with the jar file downloads.  I will investigate further.

Comment 5

[Jono Xia]

...But it still works for me on my Mac, and for Tracy on Win 7.  It seems to be only Win XP where the jar file downloads are corrupted.  Changing name of this bug to be more descriptive.

Comment 6

[Tracy Walker [:tracy]]

(In reply to comment #1)

> I can click the Feedback button and see the menu, but when I get the All Your
> Studies window, it says "Loading, please wait..." forever.  (Tracy, is this the
> same behavior you saw, or is it different?)

For me the button doesn't show the menu.  I have an old slow XP box.

Comment 7

[Tracy Walker [:tracy]]

(In reply to comment #6)
> (In reply to comment #1)
> 
> > I can click the Feedback button and see the menu, but when I get the All Your
> > Studies window, it says "Loading, please wait..." forever.  (Tracy, is this the
> > same behavior you saw, or is it different?)
> 
> For me the button doesn't show the menu.  I have an old slow XP box.

ack, with a clean profile on beta12 on XP, I see "Loading, please wait..." forever.  :-(

Feedback/TP is not going to be included in Fx4 RC's/Final, correct?

Comment 8

[Tracy Walker [:tracy]]

Hmmm, it just worked on that same clean beta12 profile.  I was notified of the User Background survey and clicking the button works and am able to access the Studies

Comment 9

[Jono Xia]

Tracy: That's pretty weird, since I haven't changed anything yet.  If it's a server problem, it may be intermittent.

Comment 10

[Jono Xia]

Redid the files and their hashes on the server and this stopped happening.  I'm going to close this for now as fixed on the server side, but let's keep an eye open for whether it starts happening again.