637387 - Entity value changed in start.dtd without changing the entity id

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Adrian Kalla [:adriank]]

Bug 486965 changed the value of the feat_labels.label entity, without changing the id. Even if according to bug 486965#c22, most localizers probably fixed this on their own, it is unacceptable, as many localizers do not check stuff that changed this way.

Also, the entity id does talk about "labels" and we have "tags" now. I propose to make the following change:

-<!ENTITY feat_labels.label "Customizable Tags and Mail Views">
+<!ENTITY feat_tags.label "Customizable Tags and Mail Views">

Comment 1

[Robert Kaiser]

I agree with this - though the change needs to be in two places, in the .dtd and in the .xhtml.

Comment 2

[:aceman]

Attachment: patch

Comment 3

[Karsten Düsterloh]

Comment on attachment 668823 [details] [diff] [review]
patch

It's a bit nasty to ask me of all people for review here, since I'm a strong fighter against the stupid "change the entity id if you're changing its value" idea. The whole point of using XML entities is NOT having to change the XML if you only alter the text! The use of broken tools is no excuse!

But in this case, I have to admit that the entity name is a bit out of sync with its content, hence r/moa=me.

Comment 4

[:aceman]

We probaby can't do better until the tools are fixed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/d2cf2e0eba3e