637440 - Cannot localize page header in mobile version

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

1) Change user-agent string to Fennec.
2) Visit https://addons.allizom.org/cs/firefox/

You can see header which is in english. We cannot translate this header at this moment.

/zamboni/templates/mobile/header.html

<div class="moz-menu">
  <ul class="menu-items">
    <li><a href="http://www.mozilla.com/en-US/mobile/">Mozilla Firefox</a></li>
    <li><a href="http://www.mozilla.com/firefox/features/">Features</a></li>
    <li><a href="http://mozilla.com/firefox/">Desktop</a></li>
    <li><a href="http://addons.mozilla.org/">Add-Ons</a></li>
    <li><a href="http://support.mozilla.com/">Support</a></li>
    <li><a href="http://mozilla.org/">Visit Mozilla</a></li>
  </ul>
  <div class="tab"><a href="#">menu</a></div>
</div>

Please remove "en-US" from URL to mobile homepage too. Thanks!

Comment 1

[Wil Clouser [:clouserw]]

I already did this earlier, just didn't close the bug. https://github.com/jbalogh/zamboni/commit/fa8490ecfd93f87c545c9a264ff3c0d5e1f69ee5

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; made sure to cover the removal of the hardcoded "/en-US/" path, too.