Closed Bug 637475 Opened 13 years ago Closed 13 years ago

get add-ons pane: localStorage used without checking if dom storage is enabled

Categories

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Product:
addons.mozilla.org Graveyard
Component:
Discovery Pane
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: al_9x, Assigned: cvan)

References

(
URL
)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

resulting in a js error:

Error: localStorage is null
Source File: https://static.addons.mozilla.net/media/js/zamboni/discovery-pane-min.js?build=ea72fbb
Line: 16

Reproducible: Always

Steps to Reproduce:
1. disable dom storage: dom.storage.enabled=false
2. open the get add-ons pane of the add-on manager or just load https://services.addons.mozilla.org/en-US/firefox/discovery/pane/4.0b12/WINNT
If we can't provide recommendations for these folks, fine, but we shouldn't be failing.
Assignee: nobody → cwiemeersch
Priority: -- → P2
Target Milestone: --- → 6.0.0
Flags: in-litmus?
another localStorage Bug 637561
Component: Public Pages → Discovery Pane
Summary: localStorage used without checking if dom storage is enabled → get add-ons pane: localStorage used without checking if dom storage is enabled
https://github.com/jbalogh/zamboni/commit/9f5b8db
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
In a new profile with dom.storage.enabled=false, I see "Sorry, couldn't retrieve.." instead of ' Recommended for you' section. Marking this as verified.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.