httpserver is a module level variable and should be encapsulated

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: k0scist, Assigned: k0scist)

Tracking

Details

(Whiteboard: [mozmill-2.0+])

(Assignee)

Description

8 years ago
For some reasons we declare the server outside of the collector class
and then manipulate this module level variable inside the collector class:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/frame.js#L305

Unless there is a reason to keep it external, it should be used
entirely within the collector class.  If there is a reason to keep it
external, it should be a parameter to Collector.  Currently it lives
at module level but is strangely manipulated (e.g. overwritten) within Collector

Updated

8 years ago
Whiteboard: [mozmill-2.0+]
That's why I have filed bug 554197 a while back to get rid of all those manipulation, also of the httpd.js code itself.
(Assignee)

Updated

8 years ago
Assignee: nobody → jhammel
(Assignee)

Comment 2

8 years ago
this is fixed with the landing of bug 638989
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.