Disco pane js is less than ideal

RESOLVED FIXED in 6.0.1

Status

P4
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: jbalogh, Assigned: cvan)

Tracking

Details

(Whiteboard: [qa-])

(Reporter)

Description

8 years ago
In addition to the sadness of bug 595991, the disco pane:

1. Has multiple js bundles
2. Loads jquery-ui
3. Loads amo2009/addons.js (to what end?)
4. Loads underscore.js
5. Contains discovery.js and discovery_pane.js (what goes where and why?)
cvan:  it sounds like you've already done some work here.  Can you give us an update and eta?
Priority: -- → P4
Target Milestone: 6.0.0 → 6.0.1
https://github.com/jbalogh/zamboni/commit/749187

1) I've consolidated the `discovery-pane` and `discovery-addon` bundles into one `discovery` bundle.
2) Removed the jquery-ui include.
3) Removed `amo/2009/addon.js` include.
4) Renamed `discovery_pane.js` to a more appropriate name, `discovery_addons.js`. What was once `discovery.js` is now `discovery_pane.js`.

I've cleaned up and organized the Recommendations code into a nice closure, which I will introduce in a commit next week.

I've also written a Storage object that abstracts the localStorage getItem/setItem/removeItem methods and falls back to cookie storage. I'd like to push this early next week as well, as it'd nicely declutter both JS files.
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: [qa-]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.