Closed Bug 637599 Opened 14 years ago Closed 14 years ago

Move nsIPlatformCharset from intl/uconv to intl/locale

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla5

People

(Reporter: smontagu, Assigned: m_kato)

References

Details

Attachments

(2 files, 1 obsolete file)

fix v2
23.49 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
for check-in
15.85 KB, patch
Details | Diff | Splinter Review 
nsIPlatformCharset implementations are the only callers of GetPlatformLocale outside intl/locale. Moving them into intl/locale will it much easier to deCOM intl/locale.
Attached patch fix (obsolete) — — Splinter Review 

  

  


Assignee: smontagu → m_kato

    
  

        Attachment #516835 -
        Flags: review?(smontagu)

    
    

    
  
Comment on attachment 516835 [details] [diff] [review]
fix

I forgot modify os2 files.

  

  



        Attachment #516835 -
        Flags: review?(smontagu)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v2
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #516835 -
        Attachment is obsolete: true

        Attachment #516853 -
        Flags: review?(smontagu)

    
  

        Attachment #516853 -
        Flags: review?(smontagu) → review+

    
  
Status: NEW → ASSIGNED
Depends on: post2.0

    
    

    
  
This needs merging to tip.

  

  


Whiteboard: [not-ready-for-cedar]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        for check-in
        — 
          — Splinter Review
      

    


  
pass on try server http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/m_kato@ga2.so-net.ne.jp-1cbaa60b1dcb/

  

  


Keywords: checkin-needed
Whiteboard: [not-ready-for-cedar]

    
    

    
  
http://hg.mozilla.org/projects/cedar/rev/b6af6b28b729

  

  


Whiteboard: fixed-in-cedar

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/b6af6b28b729

  

  


Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2

    
    

    
  
Why nsICharsetAlias is also moved? It is not used in intl/locale, but in intl/uconv.

  

  



    
    

    
  
(In reply to comment #8)
> Why nsICharsetAlias is also moved? It is not used in intl/locale, but in
> intl/uconv.

nsICharsteAlias uses nsUConvPropertySearch.

  

  



          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: