Closed Bug 637631 Opened 9 years ago Closed 9 years ago

DOM manipulation in EditorSetDefaultPrefsAndDoctype marks page as modified and undoable

Categories

(SeaMonkey :: Composer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

(Keywords: regression)

Attachments

(1 file)

DOM manipulation used to bypass the editor. However something changed since Gecko 1.9.1 and now the DOM manipulation to set the page author and other properties causes the editor to believe that it is modified and has undo items.

Steps to reproduce problem:
1. Start with a blank page to edit
2. Try to close the window

Expected result: window closes

Actual result: prompt to save changes
Attached patch Proposed patchSplinter Review
Setting the document character set was always an editor operation, which is why it was protected. This just moves the protection to cover the entire function.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #515889 - Flags: review?(ehsan)
Comment on attachment 515889 [details] [diff] [review]
Proposed patch

r=me.
Attachment #515889 - Flags: review?(ehsan) → review+
Pushed changeset 0a0ea3bfcb9c to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Pushed changeset ba945a3fb9b3 to comm-central.

I can't believe I moved the wrong line by mistake :-(
You need to log in before you can comment on or make changes to this bug.