The calendar panel doesn't collapse at the right width when dragging the splitter.

RESOLVED FIXED in 1.0b4

Status

Calendar
Calendar Views
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Decathlon, Assigned: Decathlon)

Tracking

Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [needed beta][no l10n impact])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This bug occurs only on Lightning 1.1a1pre.

Steps to reproduce:
1. Switch to calendar mode or task mode;
2. drag the left side splitter to the left.

Actual result:
when the splitter touches the right side of the minimonth, the panel doesn't collapse and its content overlaps the calendar view and remains visible beyond the splitter on the calendar/task view.
The panel collapses only when the splitter gets nearly the middle of the minimonth.
(Assignee)

Comment 1

8 years ago
Created attachment 515919 [details] [diff] [review]
patch - v1

The patch merely removes the minwidth attribute to the "ltnSidebar" vbox in order to let its children (minimonth + margins) set the minimum width.
 
Adding a minwidth="100" to the separator ensures the same exact behavior of Lightning 1.0b2. Without that, when the user removes both, the minimonth and the calendars list, the panel doesn't have anymore a mimimum width that makes it collapse when dragging the splitter. Maybe this might also be a wanted behavior and that code line could be deleted.

Instead if we want to make the minimum width smaller than the minimonth, something like this works:

       <hbox id="calendarContent" flex="1">
         <vbox id="ltnSidebar"
-              minwidth="100"
+              style="min-width: 160px; overflow: hidden;"
               width="200"
               persist="collapsed width">

Anyway I have not understood why Lg 1.1's behavior is different from Lg 1.0.
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attachment #515919 - Flags: review?(philipp)
Flags: blocking-calendar1.0+
Whiteboard: [needed beta][no l10n impact][needs review]
Comment on attachment 515919 [details] [diff] [review]
patch - v1

(In reply to comment #1)
> Adding a minwidth="100" to the separator ensures the same exact behavior of
> Lightning 1.0b2. Without that, when the user removes both, the minimonth and
> the calendars list, the panel doesn't have anymore a mimimum width that makes
> it collapse when dragging the splitter. Maybe this might also be a wanted
> behavior and that code line could be deleted.
An empty panel doesn't really make sense anyway, but I think we should keep the minwidth of the splitter. I've also added an id to that splitter.

> Instead if we want to make the minimum width smaller than the minimonth,
> something like this works:
I think we should make the minimum width match the actual element size.

r=philipp
Attachment #515919 - Flags: review?(philipp) → review+
Whiteboard: [needed beta][no l10n impact][needs review] → [needed beta][no l10n impact]
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/bbb735ecdb1b>
-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
You need to log in before you can comment on or make changes to this bug.