63767 - Insertion of separators in Personal Toolbar causes crash

Status: VERIFIED DUPLICATE of bug 62401

(SeaMonkey :: Bookmarks & History, defect)

Description

[L.M. de Vries]

Open the manage bookmarks component.
Insert a separator in one of your folders on the personal toolbar.
PROBLEM 1: Separator is not shown at first.
Close Manage Bookmarks.
Re-Open Manage Bookmarks. Now the separator is shown.
Restart Mozilla.
MAIN PROBLEM: Now the separator magically results into multiple separators.
After some time (restarting mozilla several times) the number of separators can
be more than 50!
Manually deleting the separators works, but on exit mozilla will crash.

Comment 1

[Diego]

Maybe something related to bug 54866: "Importing ns4 bookmarks does not filter
out bad chars. Recursion happens."
See also its dupes.

Comment 2

[Keyser Sose]

Definate duplicate marking as such

*** This bug has been marked as a duplicate of 54866 ***

Comment 3

[Håkan Waara]

Ksosez: Are you sure this is a dupe? I certainly isn't.

Comment 4

[L.M. de Vries]

I think you're right that it could be caused by importing Netscape 4 Bookmarks.
When I create a new account with new bookmarks and try the same thing, I do not
have any problems with the separators.

Comment 5

[Claudius Gayle]

I'm not convinced this is a dupe yet...

Comment 6

[Blake Ross]

I'm not either...

Comment 7

[L.M. de Vries]

Attachment: Small Bookmarks file that will cause crash,when inserting separator

Comment 8

[L.M. de Vries]

Mozilla Build: 2001011604 (WinME)
I have removed everything from my bookmarks-file, except for 1 folder in the
Personal Toolbar.
When inserting a separator into this folder, mozilla will crash on exit.
This smaller version of my bookmarks file does NOT have the multplying separator
problem, but I do think that the crash is related. That's why I have attached
the small bookmarks-file to this bug

Comment 9

[Claudius Gayle]

tell me again the steps so I can reproduce this crash with the BM file you've attached
(so I can confirm this bug and check other platforms)

Comment 10

[Keyser Sose]

Marking NEW while you guys figure this out.

Comment 11

[Boris Zbarsky [:bzbarsky]]

When I try to do this in a Linux debug build I can reproduce the crash on exit.
 Attaching stack trace...

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: stack trace

Comment 13

[Keyser Sose]

Adding crash, regression keyword.

Triaging the Most doomed (which Happens to Ben right now :)

Comment 14

[Paul Chen]

Gotta fix this, setting target milestone to mozilla0.8.1, reassigning to pchen
to investigate crash

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

I see this too, only after adding a separator. Curiously, the crash seems to be 
spawned by the pref shutdown procedure. cc'ing alec who may be able to provide 
some insight...

Comment 16

[Alec Flett]

the crash in the stack trace is the crash in bug 62401 (mozilla 0.8.1) - so I
don't know if you want to remove the 'crash' attribute of this bug, but I'd
recommend it..

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Making dependant on 62401, removing the crash keyword per recommendation. 

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

swapping dependency for dup since there's no problem with the separator 
insertion itself, there's just an additional crash

*** This bug has been marked as a duplicate of 62401 ***

Comment 19

[Claudius Gayle]

VERIFIED Dupe