Closed
Bug 637814
Opened 13 years ago
Closed 13 years ago
Slot accessors should be C++ public if they are AS3 public
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file)
|
42.28 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
The slot-accessor wrappers that nativegen emits are all "protected" currently; at a minimum, if the accessor is "public" in AS3 it should also be public in C++.
Attachment #515976 -
Flags: review?(rreitmai)
Attachment #515976 -
Flags: feedback?(chrisb)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 515976 [details] [diff] [review] Patch "if the accessor is "public" in AS3 it should also be public in C++." I'll take your word for it; but its not clear to me why this needs to be so, unless the architecture maps as3 and c++ mostly 1-1.
Attachment #515976 -
Flags: review?(rreitmai) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
(In reply to comment #1) > I'll take your word for it; but its not clear to me why this needs to be so, > unless the architecture maps as3 and c++ mostly 1-1. It does.
|
|
Reporter | |
Comment 3•13 years ago
|
||
TR 6028:08620371cc69
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•13 years ago
|
Attachment #515976 -
Flags: feedback?(chrisb)
You need to log in
before you can comment on or make changes to this bug.
Description
•