637936 - Kinetic panning sometimes fails when swiping away from a sidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open a web page and zoom in.
2. Drag to open the left sidebar.
3. Swipe quickly to pan away from the left sidebar.

Expected results: Kinetic panning should cause Fennec to keep panning until it reaches the other side of the page.  It will stop before opening the right sidebar (bug 607657).

Actual results: Kinetic panning does not happen; scrolling stops in the middle of the page, as soon as your finger is lifted from the screen.

This happens because doffset.x at this point often has values like 4.76e-7 that are *almost* but not exactly zero.  We need to round it to the nearest pixel before comparing it.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 2

[Benjamin Stover (:stechz)]

Comment on attachment 516286 [details] [diff] [review]
patch

I wonder if there's a place further up the stream where this makes more sense to fix, but this is what I would have done too at this point. :)

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/112625ae1e63

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: followup

Can't use "dx" as a variable name because it is a parameter of this function.  This patch just changes the name.

Comment 5

[Matt Brubeck (:mbrubeck)]

followup: http://hg.mozilla.org/mobile-browser/rev/a365b4676758

Comment 6

[Ayan Shah[:ashah]]

Verified:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b13pre)
Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre.