Add-ons manager does not return results when searching for preliminarily reviewed add-ons

VERIFIED FIXED in mozilla2.0

Status

()

defect
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: krupa.mozbugs, Assigned: mossop)

Tracking

Trunk
mozilla2.0
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [addons-testday], )

Attachments

(2 attachments)

Reporter

Description

8 years ago
Posted image screenshot
steps to reproduce:
1. Load https://addons.allizom.org/en-US/firefox/api/1.5/search/whereamo/all/30/Darwin/
2. Notice that search returns the preliminarily reviewed add-on
3. Search for 'where am o?' add-on in the add-ons manager (Tools->Add-ons)

observed behavior:
Add-ons manager does not return results when searching for preliminarily reviewed add-ons
In the API results they have a status of 8 where historically we have only listed add-ons with a status of 4 (Public). What is the full list of statuses here and is it easier to make the API output 4 for the right cases than backporting patches to all the branches of Firefox?
(In reply to comment #1)
> In the API results they have a status of 8 where historically we have only
> listed add-ons with a status of 4 (Public). What is the full list of statuses
> here and is it easier to make the API output 4 for the right cases than
> backporting patches to all the branches of Firefox?

That's something I also have suspected earlier today in an email thread with Krupa. CC'ing Justin to get the list of all available states.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Hmm, I didn't realize the Add-ons Manager filters by status. It should really show all results the API gives, as the API won't give anything that's unsuitable for such purposes.

I'm also fine with not backporting this to previous versions... if we could fix it in Firefox 4 that would be sufficient. As the Add-ons Manager isn't the only API consumer, we probably shouldn't lie about the status.
(In reply to comment #3)
> Hmm, I didn't realize the Add-ons Manager filters by status. It should really
> show all results the API gives, as the API won't give anything that's
> unsuitable for such purposes.

The API used to return sandboxed items which is why we implemented the filtering. Does it return unreviewed things right now?

> I'm also fine with not backporting this to previous versions... if we could fix
> it in Firefox 4 that would be sufficient. As the Add-ons Manager isn't the only
> API consumer, we probably shouldn't lie about the status.

Ok I'll work up a patch to remove the restrictions now, obviously no guarantees we can get it in at this point but we should be able to.
(In reply to comment #4)
> (In reply to comment #3)
> > Hmm, I didn't realize the Add-ons Manager filters by status. It should really
> > show all results the API gives, as the API won't give anything that's
> > unsuitable for such purposes.
> 
> The API used to return sandboxed items which is why we implemented the
> filtering. Does it return unreviewed things right now?

The only way to access an unreviewed add-on is to go directly to its details page; we don't show them in browse, search, or API results. So it's safe to install everything you see browsing around AMO. The same is true of the API.
Posted patch patch rev 1Splinter Review
Simple fix removes the restrictions and tests.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #516376 - Flags: review?(robert.bugzilla)
Comment on attachment 516376 [details] [diff] [review]
patch rev 1

Looks fine and safe enough based on the comments.
Attachment #516376 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 516376 [details] [diff] [review]
patch rev 1

Would love to land this for Firefox 4 to avoid AMO having to make bad changes to their API to support us. Without something many add-ons won't get displayed in the search results and this should be really safe
Attachment #516376 - Flags: approval2.0?
Comment on attachment 516376 [details] [diff] [review]
patch rev 1

Grilled Mossop on IRC, this sounds safe for omg-rc-soon.
Attachment #516376 - Flags: approval2.0? → approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/a6eb991e7f05
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Status: RESOLVED → VERIFIED
Whiteboard: [addons-testday]
You need to log in before you can comment on or make changes to this bug.