638116 - use different background gradient colors in split menu buttons in Firefox Button

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Spun out from bug 628049
	
>Comment on attachment 515992 [details]
>Modified start menu
>
>Stephen, can you suggest a prettier version that still makes it very clear to
>the user that the main command is an actual click target.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: Faaborg's mockup of better split menu button gradients

Comment 2

[:Margaret Leibovic]

Comment on attachment 516279 [details]
Faaborg's mockup of better split menu button gradients

One concern I have about this is that it implies that we want to change the hover style for all menuitems in the firefox button menu, which creates even more style rules to override the native defaults.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Quick fix

Same style for split and normal, and a clearer differentiation between the two parts to indicate that the main command is click-able.

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 516279 [details]
Faaborg's mockup of better split menu button gradients

This is on the right track. I think we should use a middle ground between the start menu style and the almost pure white style here. I will post a mockup.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Between native and Faaborg's mockup

Comment 6

[:Margaret Leibovic]

Attachment: quick fix patch

This is my implementation of Alex's quick fix. He really wants this to make it in, so it would be sweet if we could get it reviewed soon!

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 516361 [details]
Between native and Faaborg's mockup

this is much nicer than the quick fix, but might not be able to make 4 since if modifies the normal sub-menus like Web developer as well.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 516364 [details] [diff] [review]
quick fix patch

>+    background: transparent;

background-image: none;

Comment 9

[:Margaret Leibovic]

(In reply to comment #8)
> Comment on attachment 516364 [details] [diff] [review]
> quick fix patch
> 
> >+    background: transparent;
> 
> background-image: none;

This doesn't work, and I believe it's because of the -moz-appearance: none;. It creates a solid blue background on the menu.

Comment 10

[:Margaret Leibovic]

Attachment: revised patch

Comment 11

[:Margaret Leibovic]

Comment on attachment 516378 [details] [diff] [review]
revised patch

Oops, just noticed this was pre-approved by beltzner.

Comment 12

[Dão Gottwald [:dao]]

(In reply to comment #9)
> It creates a solid blue background on the menu.

So the background color is otherwise present but hidden by the opaque gradient. Can you fix that?

Comment 13

[:Margaret Leibovic]

Attachment: patch v3

Comment 14

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/bb7ae274c271