Closed Bug 638116 Opened 9 years ago Closed 9 years ago

use different background gradient colors in split menu buttons in Firefox Button

Categories

(Firefox :: Theme, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0
Tracking Status
blocking2.0 --- -

People

(Reporter: beltzner, Assigned: Margaret)

References

Details

(Keywords: polish, ux-affordance)

Attachments

(4 files, 2 obsolete files)

Spun out from bug 628049
	
>Comment on attachment 515992 [details]
>Modified start menu
>
>Stephen, can you suggest a prettier version that still makes it very clear to
>the user that the main command is an actual click target.
Comment on attachment 516279 [details]
Faaborg's mockup of better split menu button gradients

One concern I have about this is that it implies that we want to change the hover style for all menuitems in the firefox button menu, which creates even more style rules to override the native defaults.
Attached image Quick fix
Same style for split and normal, and a clearer differentiation between the two parts to indicate that the main command is click-able.
Comment on attachment 516279 [details]
Faaborg's mockup of better split menu button gradients

This is on the right track. I think we should use a middle ground between the start menu style and the almost pure white style here. I will post a mockup.
Attachment #516279 - Flags: ui-review?(shorlander) → ui-review-
Attached patch quick fix patch (obsolete) — Splinter Review
This is my implementation of Alex's quick fix. He really wants this to make it in, so it would be sweet if we could get it reviewed soon!
Assignee: shorlander → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #516364 - Flags: review?(dao)
Comment on attachment 516361 [details]
Between native and Faaborg's mockup

this is much nicer than the quick fix, but might not be able to make 4 since if modifies the normal sub-menus like Web developer as well.
Attachment #516361 - Flags: ui-review+
Comment on attachment 516364 [details] [diff] [review]
quick fix patch

>+    background: transparent;

background-image: none;
Attachment #516364 - Flags: review?(dao) → review+
Attachment #516351 - Flags: ui-review?(shorlander)
(In reply to comment #8)
> Comment on attachment 516364 [details] [diff] [review]
> quick fix patch
> 
> >+    background: transparent;
> 
> background-image: none;

This doesn't work, and I believe it's because of the -moz-appearance: none;. It creates a solid blue background on the menu.
Attached patch revised patch (obsolete) — Splinter Review
Attachment #516364 - Attachment is obsolete: true
Attachment #516378 - Flags: review?(dao)
Attachment #516378 - Flags: approval2.0?
Comment on attachment 516378 [details] [diff] [review]
revised patch

Oops, just noticed this was pre-approved by beltzner.
Attachment #516378 - Flags: approval2.0?
(In reply to comment #9)
> It creates a solid blue background on the menu.

So the background color is otherwise present but hidden by the opaque gradient. Can you fix that?
Attached patch patch v3Splinter Review
Attachment #516378 - Attachment is obsolete: true
Attachment #516378 - Flags: review?(dao)
Attachment #516394 - Flags: review?(dao)
Attachment #516394 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/bb7ae274c271
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [pre-approved by beltzner]
Target Milestone: --- → Firefox 4.0
You need to log in before you can comment on or make changes to this bug.