Add LIR-only listing mode: -Dverbose=lir

RESOLVED FIXED in Q3 11 - Serrano

Status

P3
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: edwsmith, Assigned: edwsmith)

Tracking

unspecified
Q3 11 - Serrano
Dependency tree / graph
Bug Flags:
flashplayer-injection -
flashplayer-qrb +
flashplayer-bug -

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

Currently, -Dverbose=jit is too coarse for doing differential testing of pure LIR output.  I want a flag that just prints generated LIR and nothing else.
(Assignee)

Updated

8 years ago
Blocks: 559967
(Assignee)

Updated

8 years ago
Attachment #516295 - Attachment is patch: true
Attachment #516295 - Attachment mime type: application/octet-stream → text/plain
Attachment #516295 - Flags: review?(wmaddox)
(Assignee)

Updated

8 years ago
Assignee: nobody → edwsmith
Priority: -- → P3
Target Milestone: --- → Q3 11 - Serrano
(Assignee)

Updated

8 years ago
Blocks: 620676
(Assignee)

Comment 1

8 years ago
This patch is slightly flawed.  It only prints LIR, but it does it twice per method -- once while being generated, then again just before running Assembler.  I'd rather get just the final LIR, but I'll have to refactor code a bit more so that LirNameMap (and possibly more) are created if *any* verbose flag is set, while guarding *all* output with at least one verbose flag.
(Assignee)

Updated

8 years ago
Blocks: 639475

Updated

8 years ago
Flags: flashplayer-injection-
Flags: flashplayer-bug-
(Assignee)

Comment 2

8 years ago
Comment on attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

Doing LIR-diffs of refactoring patches will be much easier once this lands.  Let me know if the "flaw" I mentioned is intolerable -- the fix looked pretty messy at first glance.  I can live with it the way it is.
Attachment #516295 - Flags: review?(wmaddox) → review?(rreitmai)

Updated

8 years ago
Flags: flashplayer-qrb+

Comment 3

8 years ago
Comment on attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

This seem fine, we can tolerate the noise for now.  Ideally we should move to a model similar to mozilla, where one can tweak each flag separately to print as little or as much information as interesting.   

Right now, we're tightly coupled with VB_jit.
Attachment #516295 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 4

8 years ago
TR: http://hg.mozilla.org/tamarin-redux/rev/38ac29fb2c6f
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.