Closed Bug 638136 Opened 14 years ago Closed 14 years ago

Add LIR-only listing mode: -Dverbose=lir

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Q3 11 - Serrano

People

(Reporter: edwsmith, Assigned: edwsmith)

References

Details

Attachments

(1 file)

Currently, -Dverbose=jit is too coarse for doing differential testing of pure LIR output. I want a flag that just prints generated LIR and nothing else.
Attachment #516295 - Attachment is patch: true
Attachment #516295 - Attachment mime type: application/octet-stream → text/plain
Attachment #516295 - Flags: review?(wmaddox)
Assignee: nobody → edwsmith
Priority: -- → P3
Target Milestone: --- → Q3 11 - Serrano
Blocks: 620676
This patch is slightly flawed. It only prints LIR, but it does it twice per method -- once while being generated, then again just before running Assembler. I'd rather get just the final LIR, but I'll have to refactor code a bit more so that LirNameMap (and possibly more) are created if *any* verbose flag is set, while guarding *all* output with at least one verbose flag.
Blocks: halfmoon
Flags: flashplayer-injection-
Flags: flashplayer-bug-
Comment on attachment 516295 [details] [diff] [review] Patch to add -Dvebose=lir, and squelch some random LIR noise. Doing LIR-diffs of refactoring patches will be much easier once this lands. Let me know if the "flaw" I mentioned is intolerable -- the fix looked pretty messy at first glance. I can live with it the way it is.
Attachment #516295 - Flags: review?(wmaddox) → review?(rreitmai)
Flags: flashplayer-qrb+
Comment on attachment 516295 [details] [diff] [review] Patch to add -Dvebose=lir, and squelch some random LIR noise. This seem fine, we can tolerate the noise for now. Ideally we should move to a model similar to mozilla, where one can tweak each flag separately to print as little or as much information as interesting. Right now, we're tightly coupled with VB_jit.
Attachment #516295 - Flags: review?(rreitmai) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: