638136 - Add LIR-only listing mode: -Dverbose=lir

Status: RESOLVED FIXED

Description

[Edwin Smith]

Created attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

Currently, -Dverbose=jit is too coarse for doing differential testing of pure LIR output.  I want a flag that just prints generated LIR and nothing else.

Comment 1

[Edwin Smith]

This patch is slightly flawed.  It only prints LIR, but it does it twice per method -- once while being generated, then again just before running Assembler.  I'd rather get just the final LIR, but I'll have to refactor code a bit more so that LirNameMap (and possibly more) are created if *any* verbose flag is set, while guarding *all* output with at least one verbose flag.

Comment 2

[Edwin Smith]

Comment on attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

Doing LIR-diffs of refactoring patches will be much easier once this lands.  Let me know if the "flaw" I mentioned is intolerable -- the fix looked pretty messy at first glance.  I can live with it the way it is.

Comment 3

[Rick Reitmaier]

Comment on attachment 516295 [details] [diff] [review]
Patch to add -Dvebose=lir, and squelch some random LIR noise.

This seem fine, we can tolerate the noise for now.  Ideally we should move to a model similar to mozilla, where one can tweak each flag separately to print as little or as much information as interesting.   

Right now, we're tightly coupled with VB_jit.

Comment 4

[Edwin Smith]

TR: http://hg.mozilla.org/tamarin-redux/rev/38ac29fb2c6f